Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default to known good version instead of latest #1684

Merged
merged 3 commits into from
Apr 7, 2025

Conversation

marschattha
Copy link
Member

We are now automatically updating latest version for most plugins but they might not always be compatible (may have breaking changes), so we should default to known_good instead of latest I believe

@Copilot Copilot bot review requested due to automatic review settings April 7, 2025 13:11
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.

Comments suppressed due to low confidence (1)

qlty-config/src/config/plugin.rs:808

  • [nitpick] Consider adding tests to verify that the new default version 'known_good' works as expected and does not introduce regressions in plugin compatibility.
"known_good".to_string()

Copy link
Contributor

qltysh bot commented Apr 7, 2025

Diff Coverage for cli: The code coverage on the diff in this pull request is 100.0%.

Total Coverage for cli: This PR will decrease coverage by 0.01%.

File Coverage Changes
Path File Coverage Δ Indirect
qlty-cli/src/auth/auth_flow.rs -0.5
🛟 Help
  • Diff Coverage: Coverage for added or modified lines of code (excludes deleted files). Learn more.

  • Total Coverage: Coverage for the whole repository, calculated as the sum of all File Coverage. Learn more.

  • File Coverage: Covered Lines divided by Covered Lines plus Missed Lines. (Excludes non-executable lines including blank lines and comments.)

    • Indirect Changes: Changes to File Coverage for files that were not modified in this PR. Learn more.

@marschattha marschattha force-pushed the ma/use_known_good_version_instead_of_latest branch from 7d19367 to 80230a9 Compare April 7, 2025 15:19
@brynary
Copy link
Member

brynary commented Apr 7, 2025

@marschattha yes, this seems like the right way to go. Do we have any gaps as in plugins where we don't have automated updates?

@marschattha
Copy link
Member Author

Yes there are a few, Radarlint plugins, Rust plugins (since they come packaged with rust) and Go plugins.

List of covered: Github, Ruby, Python, Php, Node and Runnable Archive/Java.

@marschattha marschattha requested a review from brynary April 7, 2025 19:01
@marschattha marschattha merged commit 2204d13 into main Apr 7, 2025
11 checks passed
@marschattha marschattha deleted the ma/use_known_good_version_instead_of_latest branch April 7, 2025 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants