BUG: updated dataframe sorting for identical values#244
Merged
Conversation
Member
Author
|
ci failures for osx are because there isn't a built prepare for osx with the new updates. here is the paired LANG PR that should be followed to confirm this is passing: |
ebolyen
approved these changes
Mar 3, 2026
Member
ebolyen
left a comment
There was a problem hiding this comment.
This is great! The actual values never changed and now the index order for zeros isn't arbitrary so we can resist future problems there.
Also it happens to make the existing sorts better via the updated util so the code became simpler.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this addresses test failures in the latest amplicon distro trial that includes some dependency updates: qiime2/distributions#1162
the issue was two-fold:
Tests have been adjusted with a tolerance and importances are now doubly sorted - first on importance values, then by the index.