Skip to content

BUG: updated dataframe sorting for identical values#244

Merged
lizgehret merged 11 commits intodevfrom
test-branch
Mar 5, 2026
Merged

BUG: updated dataframe sorting for identical values#244
lizgehret merged 11 commits intodevfrom
test-branch

Conversation

@lizgehret
Copy link
Member

@lizgehret lizgehret commented Mar 2, 2026

this addresses test failures in the latest amplicon distro trial that includes some dependency updates: qiime2/distributions#1162

the issue was two-fold:

  1. differing level of decimal place accuracy in the importances (at values very close to zero)
  2. differing sort orders for identical values (primarily the list of zeros in importances)

Tests have been adjusted with a tolerance and importances are now doubly sorted - first on importance values, then by the index.

@lizgehret lizgehret changed the title testing 123... BUG: updated dataframe sorting for identical values Mar 3, 2026
@github-project-automation github-project-automation bot moved this to Backlog in 2026.4 🌱 Mar 3, 2026
@lizgehret lizgehret moved this from Backlog to Needs Review in 2026.4 🌱 Mar 3, 2026
@lizgehret
Copy link
Member Author

ci failures for osx are because there isn't a built prepare for osx with the new updates. here is the paired LANG PR that should be followed to confirm this is passing:

qiime2/distributions#1178

Copy link
Member

@ebolyen ebolyen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great! The actual values never changed and now the index order for zeros isn't arbitrary so we can resist future problems there.

Also it happens to make the existing sorts better via the updated util so the code became simpler.

@github-project-automation github-project-automation bot moved this from Needs Review to Ready for Merge in 2026.4 🌱 Mar 3, 2026
@lizgehret lizgehret merged commit 802233e into dev Mar 5, 2026
6 of 8 checks passed
@github-project-automation github-project-automation bot moved this from Ready for Merge to Changelog Needed in 2026.4 🌱 Mar 5, 2026
@lizgehret lizgehret deleted the test-branch branch March 5, 2026 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Changelog Needed

Development

Successfully merging this pull request may close these issues.

2 participants