Feature/angular strict/qgrid ngx plugins #616
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merge master into forked repo
Dalantren
commented
May 19, 2022
| column: ColumnModel; | ||
| getValue: (row: any) => any; | ||
| reference: { commit: Command; cancel: Command; value: any }; | ||
| createDefaultModel?: () => Model; |
There was a problem hiding this comment.
added this property.
Rest file didn't changed
FinalButterfly
approved these changes
May 20, 2022
…e/angular-strict/qgrid-ngx-plugins
…angular-strict/qgrid-ngx-plugins-2
…e/angular-strict/qgrid-ngx-plugins
Dalantren
commented
May 26, 2022
| @@ -1,6 +1,6 @@ | |||
| export declare interface Validator { | |||
| validate(value: any): boolean; | |||
| getErrors(): Array<string>; | |||
There was a problem hiding this comment.
@klumba12 check here, please. I updated this type because Validator is using LIVR and this return type described in livr.d.ts.
Dalantren
commented
May 26, 2022
| @@ -1,41 +1,41 @@ | |||
| import { isArray, isFunction, isObject } from '@qgrid/core'; | |||
|
|
|||
| export function evaluateFactory(expression, args) { | |||
| return visit; | |||
| export type Evaluated<T> = | |||
There was a problem hiding this comment.
just for example:
interface A {
b: number;
c: string[];
d: () => string;
e: Array<() => boolean>
f: {
a: string;
b: () => number
}
}
...
Evaluated<A> is {
b number;
c: string[];
d: string;
e: Array<boolean>;
f: {
a: string;
b: number;
}
}
klumba12
reviewed
May 27, 2022
| @@ -1,12 +1,14 @@ | |||
| import { Model } from '../model/model'; | |||
|
|
|||
| export interface RestSerialized { | |||
| @@ -13,15 +13,15 @@ export class AutoCompleteEditorComponent { | |||
| return this.plugin.view.edit.cell; | |||
| } | |||
|
|
|||
| options: any[] = []; | |||
| options: unknown[] = []; | |||
| @@ -8,18 +8,20 @@ import { | |||
| } from '@angular/core'; | |||
| import { BoolColumnModel } from '@qgrid/core'; | |||
|
|
|||
| type ValueType = unknown; | |||
| @@ -17,11 +17,11 @@ import { GridModel, GridPlugin } from '@qgrid/ngx'; | |||
| changeDetection: ChangeDetectionStrategy.OnPush, | |||
| }) | |||
| export class DataProviderComponent implements OnInit { | |||
| private next: (rows: any[]) => void; | |||
| private next: (rows: unknown[]) => void; | |||
There was a problem hiding this comment.
lets use the same DataRow?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.