-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pinned rows navigation - draft #591
Open
gwhrus
wants to merge
7
commits into
qgrid:master
Choose a base branch
from
gwhrus:PinnedRowsNav
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
1b0bd8f
pager - dont propagate button press
gwhrus fcd76b2
draft - pinned rows navigation
gwhrus 57964ec
pinned rows: fix for scrolling and cell navigating
gwhrus 115e405
pinned rows - fixes
gwhrus fee7f2c
small fix
gwhrus 2acb7cd
style and nav fixes in grid with pinned rows
gwhrus ddc0190
Pinned rows - added to scene
gwhrus File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -44,8 +44,9 @@ export class View extends Unit { | |
} | ||
|
||
isFocused() { | ||
return this.getElementsCore('body') | ||
.some(element => this.isFocusedCore(element)); | ||
return this.getElementsCore('body').some(element => this.isFocusedCore(element)) || | ||
this.getElementsCore('body-top').some(element => this.isFocusedCore(element)) || | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. fix formatting, add offset |
||
this.getElementsCore('body-bottom').some(element => this.isFocusedCore(element)); | ||
} | ||
|
||
addLayer(name) { | ||
|
@@ -107,12 +108,12 @@ export class View extends Unit { | |
bodyMid.scrollLeft = value; | ||
} | ||
|
||
const bodyTop = markup['body-top']; | ||
const bodyTop = markup['body-top-mid']; | ||
if (bodyTop) { | ||
bodyTop.scrollLeft = value; | ||
} | ||
|
||
const bodyBottom = markup['body-bottom']; | ||
const bodyBottom = markup['body-bottom-mid']; | ||
if (bodyBottom) { | ||
bodyBottom.scrollLeft = value; | ||
} | ||
|
@@ -157,7 +158,16 @@ export class View extends Unit { | |
break; | ||
} | ||
case 'top': { | ||
return true; | ||
target = target.element; | ||
if (target) { | ||
const { markup } = this.context; | ||
const bodyLeft = markup['body-left']; | ||
const bodyMid = markup['body-mid']; | ||
const bodyRight = markup['body-right']; | ||
return (bodyLeft && isParentOf(bodyLeft, target)) || | ||
(bodyMid && isParentOf(bodyMid, target)) || | ||
(bodyRight && isParentOf(bodyRight, target)); | ||
} | ||
} | ||
} | ||
} | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,8 @@ | ||
/** | ||
* Indicates if row should be frozen. | ||
* - `'top'` - freeze a row on the grid's top. | ||
* - `'body'` - do not freeze | ||
* - `'bottom'` - freeze a row on the grid's bottom. | ||
*/ | ||
export declare type RowModelPin = 'top' | 'body' | 'bottom'; | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Adding this and factory pattern?