-
-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: upgrade to Fedora 41 #59595
base: master
Are you sure you want to change the base?
ci: upgrade to Fedora 41 #59595
Conversation
🪟 Windows buildsDownload Windows builds of this PR for testing. 🪟 Windows Qt6 buildsDownload Windows Qt6 builds of this PR for testing. 🧮 Vcpkg update reportRemoved packages: |
Tests failed for Qt 6One or more tests failed using the build from commit 9b67e7c composerlabel_renderhtml (renderAsHtml)composerlabel_renderhtmlTest failed at renderAsHtml at tests/src/core/testqgslayoutlabel.cpp:312 Rendered image did not match tests/testdata/control_images/composer_label/expected_composerlabel_renderhtml/expected_composerlabel_renderhtml.png (found 6342 pixels different) composerlabel_renderhtmllineheight (renderAsHtmlLineHeight)composerlabel_renderhtmllineheightTest failed at renderAsHtmlLineHeight at tests/src/core/testqgslayoutlabel.cpp:340 Rendered image did not match tests/testdata/control_images/composer_label/expected_composerlabel_renderhtmllineheight/expected_composerlabel_renderhtmllineheight.png (found 28075 pixels different) picture_svg_unlocked_aspectpicture_svg_unlocked_aspectTest failed at testRenderSvgUnlockedAspect at tests/src/python/test_qgsannotationpictureitem.py:878 Rendered image did not match tests/testdata/control_images/annotation_layer/expected_picture_svg_unlocked_aspect/expected_picture_svg_unlocked_aspect.png (found 3748 pixels different) The full test report (included comparison of rendered vs expected images) can be found here. Further documentation on the QGIS test infrastructure can be found in the Developer's Guide. |
@nyalldawson good progress 😃 5 tests have been fixed |
Yes, I'll take a look |
360dd0d
to
911d47e
Compare
@troopa81 there is still some CMYK assert failing |
cc0a71d
to
9cece4f
Compare
Since #59834 , We got the current failure comment
I opened an issue in PyQt-builder Python-PyQt/PyQt-builder#25 I could maybe check the abi version in cmake but it requires even more cmake code, and is I think overkill without the issue. I'd rather wait (for now) for it to be fixed upstream. |
temporary measure:
|
@t0b3 maybe you could pin sip at the older version in dnf? |
The QGIS project highly values your contribution and would love to see this work merged! Unfortunately this PR has not had any activity in the last 14 days and is being automatically marked as "stale". If you think this pull request should be merged, please check
|
@nyalldawson there are 3 more tests failing now PyQgsAnnotationPictureItem |
@t0b3 odd, those new ones all pass locally for me. Looks like some locale based issue given the reported failure. |
FYI, the SVG tests rendered with Qt >= 6.8 are correct, Qt 5 was not rendering the shadow properly. So the failure is actually an improvement now :) |
@nirvn I would very welcome your commits to this PR (or a separate PR, whichever you feel better about) to advance things and bring CI tests to life and bump to Fedora41 soon. would you like to help? |
clang v18 warns about ... src/core/painting/qgsmaskpaintdevice.h:36:5: note: 'QgsMaskPaintEngine' has been explicitly marked deprecated here Q_DECL_DEPRECATED QgsMaskPaintEngine( bool usePathStroker = false ); ... while still being used in src/core/painting/qgsmaskpaintdevice.cpp:65:23: note: in instantiation of function template specialization 'std::make_unique<QgsMaskPaintEngine, bool &>' requested here mPaintEngine = std::make_unique<QgsMaskPaintEngine>( usePathStroker );
ci: upgrade to Fedora 41