add Python 3.13t support #5
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
there's an open PR (huggingface/tokenizers#1774) for tokenizers which adds 3.13t support. after that gets merged this PR will make fastembed 3.13t compatible |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I haven't been using Fastembed lately, but decided to replace my little ONNX wrapper with Fastembed just to tidy it up.
that's when I noticed that Fastembed silently dies on import in Python 3.13t, so here's the fix I'm currently using.
this PR:
moves Fastembed closer to Python 3.13t compatibility
updates pyo3 dependency to support Python 3.13t
slightly updates Rust code
updates (unused?) test
tested on Python 3.12 and Python 3.13.3+ free-threaded.
closes #4
edit: I haven't tested the workflow, but I looked at the Github actions before I updated the workflow, and my changes should be fine.