-
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
feat: add example to setDefinedName #2229
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your PR. I've left some comments.
99025fc to
24ba822
Compare
|
@xuri |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2229 +/- ##
=======================================
Coverage 99.34% 99.34%
=======================================
Files 32 32
Lines 25599 25599
=======================================
Hits 25432 25432
Misses 89 89
Partials 78 78
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Could you please clarify the policy for merging this same commit into v2? After merging this, can I create a separate PR for the v2 branch? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks for your contribution. You needn't create separate PR for v2 branch, I will rebase this to v2 later.
|
Should I be worried about the dropped dough? |
PR Details
add example to setDefinedName
Description
I'm actively using your project, including implementing a full-featured Excel document import and export, but I was missing an example for this particular function. The first example mentions the option to omit the scope, but the example itself does. I also thought it would be helpful to add an example with the function, since it works.
Related Issue
Motivation and Context
as I indicated above, it is in this function that I would like to see more examples, especially with the function
How Has This Been Tested
Types of changes
Checklist