Skip to content

Conversation

@kenny-not-dead
Copy link
Contributor

@kenny-not-dead kenny-not-dead commented Oct 28, 2025

PR Details

add example to setDefinedName

Description

I'm actively using your project, including implementing a full-featured Excel document import and export, but I was missing an example for this particular function. The first example mentions the option to omit the scope, but the example itself does. I also thought it would be helpful to add an example with the function, since it works.

Related Issue

Motivation and Context

as I indicated above, it is in this function that I would like to see more examples, especially with the function

How Has This Been Tested

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Copy link
Member

@xuri xuri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your PR. I've left some comments.

@xuri xuri added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 28, 2025
@kenny-not-dead
Copy link
Contributor Author

@xuri
Thanks for your comment, I've corrected it

@codecov
Copy link

codecov bot commented Oct 28, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.34%. Comparing base (f0a56d6) to head (24ba822).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2229   +/-   ##
=======================================
  Coverage   99.34%   99.34%           
=======================================
  Files          32       32           
  Lines       25599    25599           
=======================================
  Hits        25432    25432           
  Misses         89       89           
  Partials       78       78           
Flag Coverage Δ
unittests 99.34% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@kenny-not-dead
Copy link
Contributor Author

@xuri

Could you please clarify the policy for merging this same commit into v2? After merging this, can I create a separate PR for the v2 branch?

Copy link
Member

@xuri xuri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for your contribution. You needn't create separate PR for v2 branch, I will rebase this to v2 later.

@kenny-not-dead
Copy link
Contributor Author

Should I be worried about the dropped dough?

@xuri xuri merged commit 78a8a43 into qax-os:master Oct 28, 2025
28 of 29 checks passed
xuri added a commit to xuri/excelize-doc that referenced this pull request Oct 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants