Skip to content

Travis -> GitHub Actions#94

Closed
MichalBryxi wants to merge 2 commits intopzuraq:masterfrom
MichalBryxi:mb/92-travis-to-github-actions
Closed

Travis -> GitHub Actions#94
MichalBryxi wants to merge 2 commits intopzuraq:masterfrom
MichalBryxi:mb/92-travis-to-github-actions

Conversation

@MichalBryxi
Copy link
Copy Markdown

  • This is the minimal set of changes I could come up with so that:
  1. We move from Travis to GitHub CI
  2. We re-enable CI to run tests on every PR
  3. We have coverage for "pinned versions" of ember-source

This fixes:

```
gyp ERR! stack Error: Python executable \"/opt/homebrew/bin/python\" is v3.14.0, which is not supported by gyp.
gyp ERR! stack You can pass the --python switch to point to Python >= v2.5.0 & < 3.0.0.
gyp ERR! stackgyp     at failPythonVersion (/Users/michal/ember/liquid-tether/node_modules/node-gyp/lib/configure.js:406:14)
 ERR! stackgyp Error: Python executable \"/opt/homebrew/bin/python\" is v3.14.0, which is not supported by gyp.
 ERR! stack     at /Users/michal/ember/liquid-tether/node_modules/node-gyp/lib/configure.js:395:9
gypgyp ERR! stack     at ChildProcess.exithandler (node:child_process:410:7)
 ERR!gyp ERR! stack     at ChildProcess.emit (node:events:508:28)
gyp ERR! stack     at maybeClose (node:internal/child_process:1101:16)
gyp ERR! stack     at Socket.<anonymous> (node:internal/child_process:457:11)
```
1) Moved from Travis to GitHub actions
2) Ran ember:try against all fixed-version scenarios
3) Needed to install `bower` as CI was failing
@MichalBryxi
Copy link
Copy Markdown
Author

Ping @RobbieTheWagner I managed to come up with less invasive way to re-enable the CI. So that the tests do run and we have some safety there.

@RobbieTheWagner
Copy link
Copy Markdown
Collaborator

Thanks @MichalBryxi! I have been working on finishing up the work I started in #85 which I think should get everything in good shape.

@RobbieTheWagner
Copy link
Copy Markdown
Collaborator

This was completed in another PR. Thanks for your hard work here!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Move to github actions

2 participants