-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NEP29 Compliance #85
base: main
Are you sure you want to change the base?
NEP29 Compliance #85
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! I wondered the same thing. About adding validate-pyproject
, also need to ask the @MatthewFlamm if it would be useful to add as it would increase run time. If it is adopted here, please consider sending an additional PR to pyvista/pyvista too.
@tkoyama010 Cool, thanks. Although, it seems to be a relatively snappy pre-commit hook. I'm not seeing much difference in runtime or resources being used. |
Codecov Report
@@ Coverage Diff @@
## main #85 +/- ##
=======================================
Coverage 92.13% 92.13%
=======================================
Files 2 2
Lines 89 89
=======================================
Hits 82 82
Misses 7 7 |
Since this package is required for testing pyvista, we can't drop python 3.8 support without dropping it in PyVista. We should probably move the discussion there. |
Oh, I see. I totally forgot this project was used in PyVista😅. |
I started pyvista/pyvista#4960 . Let's discuss it there! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Keep this while we discuss it.
Whilst we await a decision on this one, I'm going to put the pull-request into |
This PR adopts the NEP29 Drop Schedule for minimum supported versions of
python
andnumpy
.When working on #84 I noticed that the PyPI versions were wrong for
pytest-pyvista
. Turns out, incorrect syntax (probably migrated fromsetup.py
orsetup.cfg
) was used to specify the requiredpython
version for the package; minor fix sorted this.Went the extra mile and also configured the validate-pyproject pre-commit hook to automate continued confidence in the
pyproject.toml
.