- 
                Notifications
    You must be signed in to change notification settings 
- Fork 559
Add helper functions getDefaultXLAGenerator and createXLAGenerator to XLA random number generator #9682
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
…` to XLA random number generator
| @qihqi do you know why do i always get build timeout? it builds successfully locally on my machine. i am not able to find any clue of the cause from the build log. please take a look | 
| @ysiraichi @qihqi can you please take a look. thanks! | 
| 
 This might be because your PR is not from a branch on this PyTorch/XLA repository. | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the PR. I think that it looks good overall.
Could you add a few C++ tests and check everything is working?
| strangely, i am no longer able to build the  @ysiraichi do you have any clue about the issue? i was previously able to build and run  | 
| Not sure what happened there. | 
| 
 i am using the tpu-contributor dev container. I got the following when i run  could this be related to build cache? or it is incompatible with my pytorch? should i sync my local pytorch version to the head? Also, i don't have local pytorch-xla installed as a python package. i am not sure if this is related. | 
| Try recompiling everything from scratch: PyTorch and PyTorch/XLA (clean the cache). | 
PRs from external repositories are timeouting on `_build_torch_xla.yml` workflow. That's because in those cases, [the remote cache is disabled][1]. In such cases, [the fixed 45 minutes][2] is not enough anymore. See, for example, PR #9682 that fails due to this timeout. Here's my plan to address this issue: - Bump the timeout by 5 minutes (this PR) - Create a disk-cache using GitHub cache actions for reducing build time on PRs from external repositories (see [#9659][3] for more information) This PR will go through the following steps: - [x] Reproduce the CI build timeout - [x] Bump the timeout by 5 minutes [1]: https://github.com/pytorch/xla/blob/df6798dfb931ce7c7fe5bed2447cd1092a5981af/.github/workflows/_build_torch_xla.yml#L36 [2]: https://github.com/pytorch/xla/blob/df6798dfb931ce7c7fe5bed2447cd1092a5981af/.github/workflows/build_and_test.yml#L44 [3]: #9659
Add helper functions getDefaultXLAGenerator and createXLAGenerator to XLA random number generator
These helper functions will be used with XLA hook later.
Refer to #9159