Support SPMD placeholder tensors #9489
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rpsilva-aws
force-pushed
the
rpsilva_spmd_placeholder
branch
from
12c858c to
88aa24f
Compare
rpsilva-aws
force-pushed
the
rpsilva_spmd_placeholder
branch
6 times, most recently
from
e09b12f to
0cdb6fb
Compare
rpsilva-aws
force-pushed
the
rpsilva_spmd_placeholder
branch
from
0cdb6fb to
3403525
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is an extension to the placeholder feature #8612 that extends the functionality to accommodate sharded tensors for SPMD. It simultaneously fixes a typo in the existing binding for collecting placeholder tensors.
Refer to #8785 for the existing survey around how to leverage the object's address as the handle address for placeholder tensors. In addition, we also introduce a placeholder specific handling for mark sharding, as it currently entails an async data transfer. Note that for sharded data, we not do generate
PjRtShardedDatasharded objects in theBackendData.This allows users to leverage placeholder tensors for staging computations in their program, without invoking any data transfer or PJRT buffers under the hood.