[torchax] Make copy_ works on different device. #9211
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yaoshiang
approved these changes
May 21, 2025
| cpu_tensor = torch.tensor([1, 2, 3]) | ||
|
|
||
| with self.env: | ||
| xla_tensor = torch.tensor([0, 0, 0]) |
There was a problem hiding this comment.
is the intent here that create a tensor within torchax.tensor.Environment sets a new default device (presumably jax")?
| with self.env: | ||
| xla_tensor = torch.tensor([0, 0, 0]) | ||
| xla_tensor.copy_(cpu_tensor) | ||
|
|
There was a problem hiding this comment.
can you assert that the xla_tensor now has the expected value? Something like
assert cpu_tensor.to_list() == xla_tensor.to_list()
assert xla_tensor.device == <expected device - e.g. the copy_ didn't mess up the device of xla_tensor>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8980