Stack pipeline benchmark per-rank-results into a single BenchmarkResult #3258
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meta-cla
bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D79537357 |
SSYernar
force-pushed
the
export-D79537357
branch
from
26426a5 to
037de09
Compare
SSYernar
added a commit
to SSYernar/torchrec
that referenced
this pull request
Aug 6, 2025
…lt (pytorch#3258) Summary: Stack pipeline benchmark per-rank-results into a single BenchmarkResult to measure overall performance across GPUs. This will cause 'intentional' **2x regression** for allocated memory metrics since we are accumulating the total memory stats across two given GPUs instead of measuring only one. After the change is landed, I will **re-register** the ServiceLab task with the new baseline metrics to avoid future false regression warnings. Differential Revision: D79537357
|
This pull request was exported from Phabricator. Differential Revision: D79537357 |
SSYernar
changed the title
SSYernar
added a commit
to SSYernar/torchrec
that referenced
this pull request
Aug 6, 2025
…lt (pytorch#3258) Summary: Stack pipeline benchmark per-rank-results into a single BenchmarkResult to measure overall performance across GPUs. This will cause 'intentional' **2x regression** for allocated memory metrics since we are accumulating the total memory stats across two given GPUs instead of measuring only one. After the change is landed, I will **re-register** the ServiceLab task with the new baseline metrics to avoid future false regression warnings. Differential Revision: D79537357
Differential Revision: D79515598
SSYernar
force-pushed
the
export-D79537357
branch
from
037de09 to
399c38e
Compare
SSYernar
added a commit
to SSYernar/torchrec
that referenced
this pull request
Aug 8, 2025
…lt (pytorch#3258) Summary: Stack pipeline benchmark per-rank-results into a single BenchmarkResult to measure overall performance across GPUs. This will cause 'intentional' **2x regression** for allocated memory metrics since we are accumulating the total memory stats across two given GPUs instead of measuring only one. After the change is landed, I will **re-register** the ServiceLab task with the new baseline metrics to avoid future false regression warnings. Reviewed By: aliafzal Differential Revision: D79537357
…lt (pytorch#3258) Summary: Pull Request resolved: pytorch#3258 Stack pipeline benchmark per-rank-results into a single BenchmarkResult to measure overall performance across GPUs. This will cause 'intentional' **2x regression** for allocated memory metrics since we are accumulating the total memory stats across two given GPUs instead of measuring only one. After the change is landed, I will **re-register** the ServiceLab task with the new baseline metrics to avoid future false regression warnings. Reviewed By: aliafzal Differential Revision: D79537357
|
This pull request was exported from Phabricator. Differential Revision: D79537357 |
SSYernar
force-pushed
the
export-D79537357
branch
from
399c38e to
0b785c1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Stack pipeline benchmark per-rank-results into a single BenchmarkResult to measure overall performance across GPUs.
This will cause 'intentional' 2x regression for allocated memory metrics since we are accumulating the total memory stats across two given GPUs instead of measuring only one. After the change is landed, I will re-register the ServiceLab task with the new baseline metrics to avoid future false regression warnings.
Differential Revision: D79537357