skip python 3.13t for pip install fbgemm-gpu #3118
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary:
# context
* validate_binaries.sh manually install torchrec dependencies and it often has an off-sync issue as below
```
+++ conda run -n build_binary python -c 'import torch; import fbgemm_gpu; import torchrec'
+++ local cmd=run
+++ case "$cmd" in
+++ __conda_exe run -n build_binary python -c 'import torch; import fbgemm_gpu; import torchrec'
+++ /opt/conda/bin/conda run -n build_binary python -c 'import torch; import fbgemm_gpu; import torchrec'
WARNING: overwriting environment variables set in the machine
overwriting variable {'LD_LIBRARY_PATH'}
Traceback (most recent call last):
File "<string>", line 1, in <module>
File "/pytorch/torchrec/torchrec/__init__.py", line 10, in <module>
import torchrec.distributed # noqa
File "/pytorch/torchrec/torchrec/distributed/__init__.py", line 38, in <module>
from torchrec.distributed.model_parallel import DistributedModelParallel # noqa
File "/pytorch/torchrec/torchrec/distributed/model_parallel.py", line 18, in <module>
from fbgemm_gpu.split_table_batched_embeddings_ops_training import (
File "/opt/conda/envs/build_binary/lib/python3.9/site-packages/fbgemm_gpu/split_table_batched_embeddings_ops_training.py", line 54, in <module>
from fbgemm_gpu.tbe.stats import TBEBenchmarkParamsReporter
File "/opt/conda/envs/build_binary/lib/python3.9/site-packages/fbgemm_gpu/tbe/stats/__init__.py", line 10, in <module>
from .bench_params_reporter import TBEBenchmarkParamsReporter # noqa F401
File "/opt/conda/envs/build_binary/lib/python3.9/site-packages/fbgemm_gpu/tbe/stats/bench_params_reporter.py", line 19, in <module>
from fbgemm_gpu.tbe.bench.tbe_data_config import (
File "/opt/conda/envs/build_binary/lib/python3.9/site-packages/fbgemm_gpu/tbe/bench/__init__.py", line 12, in <module>
from .bench_config import ( # noqa F401
Traceback (most recent call last):
File "/home/ec2-user/actions-runner/_work/torchrec/torchrec/test-infra/.github/scripts/run_with_env_secrets.py", line 102, in <module>
File "/opt/conda/envs/build_binary/lib/python3.9/site-packages/fbgemm_gpu/tbe/bench/bench_config.py", line 14, in <module>
import click
ModuleNotFoundError: No module named 'click'
ERROR conda.cli.main_run:execute(47): `conda run python -c import torch; import fbgemm_gpu; import torchrec` failed. (See above for error)
main()
File "/home/ec2-user/actions-runner/_work/torchrec/torchrec/test-infra/.github/scripts/run_with_env_secrets.py", line 98, in main
run_cmd_or_die(f"docker exec -t {container_name} /exec")
File "/home/ec2-user/actions-runner/_work/torchrec/torchrec/test-infra/.github/scripts/run_with_env_secrets.py", line 39, in run_cmd_or_die
raise RuntimeError(f"Command {cmd} failed with exit code {exit_code}")
RuntimeError: Command docker exec -t 96827edf14ff626b7bc16b6cfaa56aa27b4b660029e1fd7755d14bf20a3c4e96 /exec failed with exit code 1
Error: Process completed with exit code 1.
```
* this diff install the requirements.txt
NOTE: the paths in workflow yaml file needs '' to protect
Differential Revision: D76875546
Summary: # context * the release validation use pip install from PYPI * fbgemm-gpu can't support python 3.13t in PYPI yet * skip python 3.13t in the release validation Differential Revision: D76998935
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D76998935 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
context
Differential Revision: D76998935