OSS TorchRec Internal MPZCH modules (#3017) #3089
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D76476676 |
Summary: Pull Request resolved: pytorch#3089 Pull Request resolved: pytorch#3017 ### Major changes - Copy the following files from `fb` to corresponding location in the `torchrec` repository - `fb/distributed/hash_mc_embedding.py → torchrec/distributed/hash_mc_embedding.py` - `fb/modules/hash_mc_evictions.py → torchrec/modules/hash_mc_evictions.py` - `fb/modules/hash_mc_metrics.py → torchrec/modules/hash_mc_metrics.py` - `fb/modules/hash_mc_modules.py → torchrec/modules/hash_mc_modules.py` - `fb/modules/tests/test_hash_mc_evictions.py → torchrec/modules/tests/test_hash_mc_evictions.py` - `fb/modules/tests/test_hash_mc_modules.py → torchrec/modules/tests/test_hash_mc_modules.py` - Create a `test_hash_zch_mc.py` file in `torchrec/distributed/tests` folder following the `test_quant_mc_embedding.py` in `torchrec/fb/distributed/tests`. - trimmed quantization and inference codes, and only kept the training part. - rewire the related packages from `torchrec.fb` to `torchrec` - Update `BUCK` files in related folders - Update the affected repos to use `torchrec` modules instead of the modules in `torchrec.fb` - Update `/modules/hash_mc_metrics.py` - Replace the tensorboard module with a local file logger in `hash_mc_metrics.py` module - Update the license declaration headers for the four OSS files ### ToDos after landing this Diff - Clean the duplicated `hash_mc_modules.py` file in the `fb` folder for safe landing. Differential Revision: D76476676
|
This pull request was exported from Phabricator. Differential Revision: D76476676 |
lizhouyu
force-pushed
the
export-D76476676
branch
from
3698e05 to
9f1c251
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Major changes
fbto corresponding location in thetorchrecrepositoryfb/distributed/hash_mc_embedding.py → torchrec/distributed/hash_mc_embedding.pyfb/modules/hash_mc_evictions.py → torchrec/modules/hash_mc_evictions.pyfb/modules/hash_mc_metrics.py → torchrec/modules/hash_mc_metrics.pyfb/modules/hash_mc_modules.py → torchrec/modules/hash_mc_modules.pyfb/modules/tests/test_hash_mc_evictions.py → torchrec/modules/tests/test_hash_mc_evictions.pyfb/modules/tests/test_hash_mc_modules.py → torchrec/modules/tests/test_hash_mc_modules.pytest_hash_zch_mc.pyfile intorchrec/distributed/testsfolder following thetest_quant_mc_embedding.pyintorchrec/fb/distributed/tests.torchrec.fbtotorchrecBUCKfiles in related folderstorchrecmodules instead of the modules intorchrec.fb/modules/hash_mc_metrics.pyhash_mc_metrics.pymoduleToDos after landing this Diff
hash_mc_modules.pyfile in thefbfolder for safe landing.Differential Revision: D76476676