Skip to content

Extend FSDP1 global clipping support for optimizers other than Shampoo #2931

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Extend FSDP1 global clipping support for optimizers other than Shampoo #2931

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion torchrec/optim/clipping.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,7 @@ def __init__(
else:
self._replicate_params.append(param)
logger.info(
f"Optimizer found {sharded_param_cnt} dist params and {len(self._replicate_params)} replicate params."
f"Clipping [Rank {dist.get_rank()}] Optimizer found {sharded_param_cnt} dist params and {len(self._replicate_params)} replicate params."
)

# Sanity check: this path is currently not used in any production.
Expand Down
Loading