avoid stream synchronization in manager #216
Merged
+34
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jun 15, 2025
Merged
facebook-github-bot
added
the
CLA Signed
tushar00jain
force-pushed
the
pr216
branch
4 times, most recently
from
1f93550 to
77b6330
Compare
Merged
H-Huang
approved these changes
Jun 16, 2025
| @@ -323,6 +326,7 @@ def allreduce( | |||
| return fut | |||
|
|
|||
| self.wait_quorum() | |||
There was a problem hiding this comment.
do we need this wait_quorum() if self.num_participants() already calls it?
There was a problem hiding this comment.
i think good to leave it here for readability
Summary: - for diloco the model parameters, in the way they are saved by the test can be different across replicas - only the global parameters can be the same - fix the test to validate the global parameters are the same instead of the local model parameters Test Plan: ``` $ pytest -v ./torchft/local_sgd_integ_test.py::LocalSGDIntegTest::test_diloco_recovery_0 ```
Summary: - use a recovery event to synchronize on instead of the recovery stream - fix calling `work.wait()` in manager - avoid calling `quorum.wait` inside of a callback Test Plan: <img width="1483" alt="Screenshot 2025-06-16 at 1 08 04 AM" src="https://github.com/user-attachments/assets/47de0853-1878-40b9-ae8e-f9fc55972917" />
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
work.wait()in managerquorum.waitinside of a callbackTest Plan:
Stack created with Sapling. Best reviewed with ReviewStack.