Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 13 additions & 3 deletions torchci/components/benchmark_v3/configs/teams/torchao/config.ts
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
import { BenchmarkUIConfig } from "lib/benchmark/store/benchmark_config_book";
import { BenchmarkComparisonPolicyConfig } from "../../helpers/RegressionPolicy";
import {
DEFAULT_COMPARISON_TABLE_METADATA_COLUMNS,
DEFAULT_DASHBOARD_BENCHMARK_INITIAL,
DEFAULT_LATENCY_POLICY,
} from "../defaults/default_dashboard_config";

export const PYTORCH_OPERATOR_MICROBENCHMARK_ID =
Expand All @@ -19,6 +19,16 @@ const initialOptions = {
},
};

export const LATENCY_POLICY: BenchmarkComparisonPolicyConfig = {
target: "latency",
type: "ratio",
ratioPolicy: {
badRatio: 1.25,
goodRatio: 0.75,
direction: "down",
},
};

const COMPARISON_TABLE_METADATA_COLUMNS = [
...DEFAULT_COMPARISON_TABLE_METADATA_COLUMNS,
{
Expand Down Expand Up @@ -98,7 +108,7 @@ export const PytorchOperatorMicroBenchmarkDashoboardConfig: BenchmarkUIConfig =
displayName: "Model",
},
comparisonPolicy: {
latency: DEFAULT_LATENCY_POLICY,
latency: LATENCY_POLICY,
},
extraMetadata: COMPARISON_TABLE_METADATA_COLUMNS,
renderOptions: {
Expand Down Expand Up @@ -137,7 +147,7 @@ export const PytorchOperatorMicroBenchmarkDashoboardConfig: BenchmarkUIConfig =
},
},
comparisonPolicy: {
latency: DEFAULT_LATENCY_POLICY,
latency: LATENCY_POLICY,
},
extraMetadata: COMPARISON_TABLE_METADATA_COLUMNS,
renderOptions: {
Expand Down
9 changes: 5 additions & 4 deletions torchci/components/benchmark_v3/pages/BenchmarkListPage.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -60,13 +60,14 @@ export const categories: BenchmarkCategoryGroup[] = [
},
{
name: "Operator Microbenchmark",
route:
"/benchmark/llms?repoName=pytorch%2Fpytorch&benchmarkName=PyTorch+operator+microbenchmark",
route: "/benchmark/v3/dashboard/pytorch_operator_microbenchmark",
info: "Powered by [code](https://github.com/pytorch/pytorch/tree/main/benchmarks/operator_benchmark)",
description:
"Use `legacy page` to see comparison view for different branches. It will be deprecated soon",
actions: [
{
label: "New dashboard (WIP)",
href: "/benchmark/v3/dashboard/pytorch_operator_microbenchmark",
label: "Legacy Page/Playground",
href: "/benchmark/llms?repoName=pytorch%2Fpytorch&benchmarkName=PyTorch+operator+microbenchmark",
},
],
},
Expand Down