Skip to content

Add source code indexing #6590

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Add source code indexing #6590

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d8ef36e
Add source code handling to manage script
zklaus Apr 30, 2025
db73741
Add source code handling to workflow
zklaus Apr 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion .github/workflows/update-s3-html.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,14 @@ jobs:
environment: pytorchbot-env
strategy:
matrix:
prefix: ["whl", "whl/test", "whl/nightly", "libtorch", "libtorch/nightly"]
prefix:
- whl
- whl/test
- whl/nightly
- libtorch
- libtorch/nightly
- source_code
- source_code/test
fail-fast: False
container:
image: continuumio/miniconda3:23.10.0-1
Expand Down
46 changes: 38 additions & 8 deletions s3_management/manage.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,8 @@
"whl/test",
"libtorch",
"libtorch/nightly",
"source_code",
"source_code/test"
]

# NOTE: This refers to the name on the wheels themselves and not the name of
Expand Down Expand Up @@ -346,27 +348,34 @@ def normalize_package_version(self: S3IndexType, obj: S3Object) -> str:
def obj_to_package_name(self, obj: S3Object) -> str:
return path.basename(obj.key).split('-', 1)[0].lower()

def to_libtorch_html(
def to_list_html(
self,
subdir: Optional[str] = None
subdir: Optional[str] = None,
package_name: Optional[str] = None
) -> str:
"""Generates a string that can be used as the HTML index

Takes our objects and transforms them into HTML that have historically
been used by pip for installing pytorch, but now only used to generate libtorch browseable folder.
been used by pip for installing pytorch, but now only used to generate browseable folders.
"""
out: List[str] = []
out.append('<!DOCTYPE html>')
out.append('<html>')
out.append(' <body>')
subdir = self._resolve_subdir(subdir)
is_root = subdir == self.prefix
for obj in self.gen_file_list(subdir, "libtorch"):
# Skip root objs, as they are irrelevant for libtorch indexes
for obj in self.gen_file_list(subdir, package_name):
# Skip root objs, as they are irrelevant for list indexes
if not is_root and self.is_obj_at_root(obj):
continue
# Strip our prefix
sanitized_obj = obj.key.replace(subdir, "", 1)
if sanitized_obj.startswith('/'):
sanitized_obj = sanitized_obj.lstrip("/")
out.append(f'<a href="/{obj.key}">{sanitized_obj}</a><br/>')
out.append(f' <a href="/{obj.key}">{sanitized_obj}</a><br/>')
out.append(' </body>')
out.append('</html>')
out.append(f'<!--TIMESTAMP {int(time.time())}-->')
return "\n".join(sorted(out))

def to_simple_package_html(
Expand Down Expand Up @@ -427,7 +436,21 @@ def to_simple_packages_html(

def upload_libtorch_html(self) -> None:
for subdir in self.subdirs:
index_html = self.to_libtorch_html(subdir=subdir)
index_html = self.to_list_html(subdir=subdir, package_name="libtorch")
for bucket in INDEX_BUCKETS:
print(f"INFO Uploading {subdir}/{self.html_name} to {bucket.name}")
bucket.Object(
key=f"{subdir}/{self.html_name}"
).put(
ACL='public-read',
CacheControl='no-cache,no-store,must-revalidate',
ContentType='text/html',
Body=index_html
)

def upload_source_code_html(self) -> None:
for subdir in {None} | self.subdirs:
index_html = self.to_list_html(subdir=subdir, package_name="pytorch")
for bucket in INDEX_BUCKETS:
print(f"INFO Uploading {subdir}/{self.html_name} to {bucket.name}")
bucket.Object(
Expand Down Expand Up @@ -471,7 +494,14 @@ def save_libtorch_html(self) -> None:
print(f"INFO Saving {subdir}/{self.html_name}")
makedirs(subdir, exist_ok=True)
with open(path.join(subdir, self.html_name), mode="w", encoding="utf-8") as f:
f.write(self.to_libtorch_html(subdir=subdir))
f.write(self.to_list_html(subdir=subdir, package_name="libtorch"))

def save_source_code_html(self) -> None:
for subdir in self.subdirs:
print(f"INFO Saving {subdir}/{self.html_name}")
makedirs(subdir, exist_ok=True)
with open(path.join(subdir, self.html_name), mode="w", encoding="utf-8") as f:
f.write(self.to_list_html(subdir=subdir, package_name="pytorch"))

def save_pep503_htmls(self) -> None:
for subdir in self.subdirs:
Expand Down