-
Notifications
You must be signed in to change notification settings - Fork 453
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix optimized log_softmax along non-contiguous dim #8595
Open
swolchok
wants to merge
2
commits into
gh/swolchok/272/base
Choose a base branch
from
gh/swolchok/272/head
base: gh/swolchok/272/base
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
#8382 certainly didn't fix this problem (and added it on x86), but I don't think it was correct on ARM prior to that either. Added a regression test. Differential Revision: [D69928884](https://our.internmc.facebook.com/intern/diff/D69928884/) [ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/8595
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New FailureAs of commit 9741c7a with merge base 139be81 ( NEW FAILURE - The following job has failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
swolchok
pushed a commit
that referenced
this pull request
Feb 20, 2025
#8382 certainly didn't fix this problem (and added it on x86), but I don't think it was correct on ARM prior to that either. Added a regression test. Differential Revision: [D69928884](https://our.internmc.facebook.com/intern/diff/D69928884/) ghstack-source-id: 267433500 Pull Request resolved: #8595
This pull request was exported from Phabricator. Differential Revision: D69928884 |
This was referenced Feb 20, 2025
#8382 certainly didn't fix this problem (and added it on x86), but I don't think it was correct on ARM prior to that either. Added a regression test. Differential Revision: [D69928884](https://our.internmc.facebook.com/intern/diff/D69928884/) [ghstack-poisoned]
This pull request was exported from Phabricator. Differential Revision: D69928884 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
CLA Signed
This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
fb-exported
release notes: ops & kernels
Changes to the opset and any new / changed kernel implementations
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
#8382 certainly didn't fix this problem (and added it on x86), but I don't think it was correct on ARM prior to that either.
Added a regression test.
Differential Revision: D69928884