Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix optimized log_softmax along non-contiguous dim #8595

Open
wants to merge 2 commits into
base: gh/swolchok/272/base
Choose a base branch
from

Conversation

swolchok
Copy link
Contributor

@swolchok swolchok commented Feb 20, 2025

Stack from ghstack (oldest at bottom):

#8382 certainly didn't fix this problem (and added it on x86), but I don't think it was correct on ARM prior to that either.

Added a regression test.

Differential Revision: D69928884

#8382 certainly didn't fix this problem (and added it on x86), but I don't think it was correct on ARM prior to that either.

Added a regression test.

Differential Revision: [D69928884](https://our.internmc.facebook.com/intern/diff/D69928884/)

[ghstack-poisoned]
Copy link

pytorch-bot bot commented Feb 20, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/8595

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure

As of commit 9741c7a with merge base 139be81 (image):

NEW FAILURE - The following job has failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Feb 20, 2025
swolchok pushed a commit that referenced this pull request Feb 20, 2025
#8382 certainly didn't fix this problem (and added it on x86), but I don't think it was correct on ARM prior to that either.

Added a regression test.

Differential Revision: [D69928884](https://our.internmc.facebook.com/intern/diff/D69928884/)

ghstack-source-id: 267433500
Pull Request resolved: #8595
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D69928884

@swolchok swolchok added the release notes: ops & kernels Changes to the opset and any new / changed kernel implementations label Feb 20, 2025
@swolchok swolchok changed the title Fix log_softmax along non-contiguous dim Fix optimized log_softmax along non-contiguous dim Feb 20, 2025
#8382 certainly didn't fix this problem (and added it on x86), but I don't think it was correct on ARM prior to that either.

Added a regression test.

Differential Revision: [D69928884](https://our.internmc.facebook.com/intern/diff/D69928884/)

[ghstack-poisoned]
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D69928884

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported release notes: ops & kernels Changes to the opset and any new / changed kernel implementations
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants