-
Notifications
You must be signed in to change notification settings - Fork 712
Error out if git symlink not enabled on Windows #15684
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
When I install executorch on windows I run into this error: error: [Errno 2] No such file or directory: 'pip-out\\lib.win-amd64-cpython-312\\executorch\\version.py' It turns out sometimes the dst directory (in this case pip-out\lib.win-amd64-cpython-312\executorch) is not installed before we write version.py into it. This PR adds a mkpath call to make sure it's always there.
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/15684
Note: Links to docs will display an error until the docs builds have been completed. ❌ 3 New Failures, 3 Unrelated FailuresAs of commit 2ebc280 with merge base 9a7882e ( NEW FAILURES - The following jobs have failed:
FLAKY - The following job failed but was likely due to flakiness present on trunk:
BROKEN TRUNK - The following jobs failed but was present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
This PR needs a
|
|
@GregoryComer @larryliu0820 cherry-pickable to 1.0.1? |
|
Oops this patch doesn't fix the underlying problem. If we don't turn on symlink on windows: Probably will abandon this. |
Following up on Mengwei's comment, I had a task for 1.0 to at least catch this any maybe try to automatically fix the symlinks. I dropped it from release blockers due to priorities, but I'll pull it into 1.0.1. |
|
I updated the PR to error out in |
GregoryComer
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding this. Looks good to me.
When I install executorch on windows I run into this error: error:
[Errno 2] No such file or directory:
'pip-out\lib.win-amd64-cpython-312\executorch\version.py'
This is because we are not enabling symlink in git.
Need to run:
and reclone the repo.
This PR fails the installation when that happens.