Skip to content

Conversation

samanklesaria
Copy link
Collaborator

As the online_asr tutorial depends on the deprecated StreamReader interface, this must be deleted before the new release.

Copy link

pytorch-bot bot commented Jul 18, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/audio/3984

Note: Links to docs will display an error until the docs builds have been completed.

❌ 7 New Failures

As of commit f48a3b1 with merge base 15193c1 (image):

NEW FAILURES - The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed label Jul 18, 2025
Copy link
Member

@NicolasHug NicolasHug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @samanklesaria

I approved, but before merging please make sure to remove the corresponding entries in the rest of the files:

~/dev/audio (main) » git grep -e device_asr -e online_asr -e device_avsr                                                                                           nicolashug@nicolashug-fedora-PW0H326Y
docs/requirements.txt:# In our case, the tutorial timed out is online_asr_tutorial,
docs/source/index.rst:   tutorials/online_asr_tutorial
docs/source/index.rst:   tutorials/device_asr
docs/source/index.rst:   tutorials/device_avsr
docs/source/index.rst:   :link: tutorials/device_avsr.html
docs/source/index.rst:   :image: https://download.pytorch.org/torchaudio/tutorial-assets/thumbnails/online_asr_tutorial.gif
docs/source/index.rst:   :link: tutorials/online_asr_tutorial.html
docs/source/index.rst:   :image: https://download.pytorch.org/torchaudio/tutorial-assets/thumbnails/device_asr.png
docs/source/index.rst:   :link: tutorials/device_asr.html
examples/tutorials/device_asr.py:# `Online ASR with Emformer RNN-T <./online_asr_tutorial.html>`__.
examples/tutorials/device_asr.py:# `Online ASR with Emformer RNN-T <./online_asr_tutorial.html>`__.
examples/tutorials/device_avsr.py:    model_path = download_asset("tutorial-assets/device_avsr_model.pt")
examples/tutorials/streamreader_advanced_tutorial.py:#    - `Online ASR with Emformer RNN-T <./online_asr_tutorial.html>`__.
examples/tutorials/streamreader_advanced_tutorial.py:#    - `Device ASR with Emformer RNN-T <./device_asr.html>`__.

On migration to torchcodec:

We do support streaming APIs in torchcodec as we support file-like objects in the AudioDecoder, but it's unclear to me whether all the features described in these tutorials are easily achievable with torchcodec. Let's see if we get more feature requests about this on the torchcodec side.

@samanklesaria samanklesaria requested a review from a team as a code owner July 29, 2025 14:09
@samanklesaria samanklesaria merged commit 4a0bbd0 into main Jul 29, 2025
43 checks passed
@samanklesaria samanklesaria deleted the remove_online_asr branch July 29, 2025 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants