-
Notifications
You must be signed in to change notification settings - Fork 674
remove pt2 compliant xfails for jagged ops #5068
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for pytorch-fbgemm-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
a90725a to
f46faaa
Compare
bdhirsh
added a commit
to bdhirsh/FBGEMM
that referenced
this pull request
Oct 29, 2025
Summary: X-link: facebookresearch/FBGEMM#2075 letting CI tell me what tests to run to fix these ops for pt2 Differential Revision: D85630006
ezyang
approved these changes
Oct 29, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review automatically exported from Phabricator review in Meta.
bdhirsh
added a commit
to bdhirsh/FBGEMM
that referenced
this pull request
Oct 30, 2025
Summary: X-link: facebookresearch/FBGEMM#2075 letting CI tell me what tests to run to fix these ops for pt2 Reviewed By: ezyang Differential Revision: D85630006
f46faaa to
ae35698
Compare
Summary: X-link: facebookresearch/FBGEMM#2075 letting CI tell me what tests to run to fix these ops for pt2 Reviewed By: ezyang Differential Revision: D85630006
ae35698 to
3ff681a
Compare
|
This pull request has been merged in 34754ea. |
Bernard-Liu
pushed a commit
to ROCm/FBGEMM
that referenced
this pull request
Oct 31, 2025
Summary: X-link: https://github.com/facebookresearch/FBGEMM/pull/2075 Pull Request resolved: pytorch#5068 letting CI tell me what tests to run to fix these ops for pt2 Reviewed By: ezyang Differential Revision: D85630006 fbshipit-source-id: dbf3795f7b1ed847882e17f3d24566e8339729fc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: letting CI tell me what tests to run to fix these ops for pt2
Differential Revision: D85630006