Skip to content

Conversation

@jasl
Copy link

@jasl jasl commented Sep 30, 2025

The issue has been fixed https://github.com/NVIDIA/cutlass/blob/v4.2.1/tools/util/include/cutlass/util/mixed_dtype_utils.hpp#L180-L184

So I switch back to the official repo and upgrade to v4.2.1, which is important for ARM Blackwell

@netlify
Copy link

netlify bot commented Sep 30, 2025

Deploy Preview for pytorch-fbgemm-docs failed.

Name Link
🔨 Latest commit 3872041
🔍 Latest deploy log https://app.netlify.com/projects/pytorch-fbgemm-docs/deploys/68eff23fd160830008bbfe1a

@meta-cla
Copy link

meta-cla bot commented Sep 30, 2025

Hi @jasl!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

@meta-cla
Copy link

meta-cla bot commented Sep 30, 2025

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

@meta-cla meta-cla bot added the cla signed label Sep 30, 2025
@facebook-github-bot
Copy link
Contributor

@q10 has imported this pull request. If you are a Meta employee, you can view this in D83578508.

@q10
Copy link
Contributor

q10 commented Sep 30, 2025

The original issue that forced us to use the cutlass fork remains:

2025-09-30T17:33:52.6122654Z /__w/FBGEMM/FBGEMM/fbgemm_gpu/../external/cutlass/tools/util/include/cutlass/util/mixed_dtype_utils.hpp(180): error: namespace "cutlass" has no member "int8_t"
2025-09-30T17:33:52.6124845Z     static_assert(cute::is_same_v<T, cutlass::int8_t> ||

@jasl
Copy link
Author

jasl commented Sep 30, 2025

The original issue that forced us to use the cutlass fork remains:

2025-09-30T17:33:52.6122654Z /__w/FBGEMM/FBGEMM/fbgemm_gpu/../external/cutlass/tools/util/include/cutlass/util/mixed_dtype_utils.hpp(180): error: namespace "cutlass" has no member "int8_t"
2025-09-30T17:33:52.6124845Z     static_assert(cute::is_same_v<T, cutlass::int8_t> ||

Ah, sorry, I read the change backwards...
Could I leave the PR for a while, and I'm asking Nvidia staff for help

@jasl
Copy link
Author

jasl commented Oct 2, 2025

@johnnynunez
This is blocking us from continuing the work on Jetson Thor. Could you help?

@q10
Copy link
Contributor

q10 commented Oct 2, 2025

Working around this with #4964, which points CUTLASS to https://github.com/jwfromm/cutlass/tree/v4.2.1-FBGEMM

@johnnynunez
Copy link
Contributor

Working around this with #4964, which points CUTLASS to https://github.com/jwfromm/cutlass/tree/v4.2.1-FBGEMM

Thanks

@IwakuraRein
Copy link

IwakuraRein commented Oct 3, 2025

@q10 Hi. Could you try adding #include "cutlass/util/type_traits.h" to that file and see if the issue remains? Thanks.

It looks like the standard int types only exist in cute namespace, not cutlass. I will create a pr to remove all cutlass::int8_t and just use int8_t like cutlass/numeric_conversion.h does.

@IwakuraRein
Copy link

FYI pr2684 has been merged into cutlass main branch

@jasl
Copy link
Author

jasl commented Oct 15, 2025

FYI pr2684 has been merged into cutlass main branch

Can I check out the NVIDIA/cutlass@e6e2cc2 ?

@jasl jasl force-pushed the upgrade-cutlass-421 branch from 2f36e2c to 3872041 Compare October 15, 2025 19:13
@jasl
Copy link
Author

jasl commented Oct 15, 2025

I switched to your commit, it should be safe, because it's the first commit prior to v4.2.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants