iRoPE (-p > 8192) #4063
Closed
iRoPE (-p > 8192) #4063
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request was exported from Phabricator. Differential Revision: D73833204 |
✅ Deploy Preview for pytorch-fbgemm-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
This pull request was exported from Phabricator. Differential Revision: D73833204 |
y-sq
added a commit
to y-sq/FBGEMM-1
that referenced
this pull request
May 21, 2025
Summary: X-link: facebookresearch/FBGEMM#1149 When the max_seq_len is larger than 8192, one input sample will be divided into multiple sequences. Such as: When bs = 2, and seqlen = 7, we will have seq_lens = [0, 7, 7, 7, 7, 14, 14, 14, 14] in the prefill attention. In decoding, it won't as it's handled by the gappy bias. Reviewed By: sijiac Differential Revision: D73833204
y-sq
added a commit
to y-sq/FBGEMM-1
that referenced
this pull request
May 21, 2025
Summary: X-link: facebookresearch/FBGEMM#1149 When the max_seq_len is larger than 8192, one input sample will be divided into multiple sequences. Such as: When bs = 2, and seqlen = 7, we will have seq_lens = [0, 7, 7, 7, 7, 14, 14, 14, 14] in the prefill attention. In decoding, it won't as it's handled by the gappy bias. Reviewed By: sijiac Differential Revision: D73833204
y-sq
added a commit
to y-sq/FBGEMM-1
that referenced
this pull request
May 21, 2025
Summary: X-link: facebookresearch/FBGEMM#1149 When the max_seq_len is larger than 8192, one input sample will be divided into multiple sequences. Such as: When bs = 2, and seqlen = 7, we will have seq_lens = [0, 7, 7, 7, 7, 14, 14, 14, 14] in the prefill attention. In decoding, it won't as it's handled by the gappy bias. Reviewed By: sijiac Differential Revision: D73833204
y-sq
added a commit
to y-sq/FBGEMM-1
that referenced
this pull request
May 21, 2025
Summary: X-link: facebookresearch/FBGEMM#1149 When the max_seq_len is larger than 8192, one input sample will be divided into multiple sequences. Such as: When bs = 2, and seqlen = 7, we will have seq_lens = [0, 7, 7, 7, 7, 14, 14, 14, 14] in the prefill attention. In decoding, it won't as it's handled by the gappy bias. Reviewed By: sijiac Differential Revision: D73833204
|
This pull request was exported from Phabricator. Differential Revision: D73833204 |
y-sq
added a commit
to y-sq/FBGEMM-1
that referenced
this pull request
May 21, 2025
Summary: Pull Request resolved: pytorch#4063 X-link: facebookresearch/FBGEMM#1149 When the max_seq_len is larger than 8192, one input sample will be divided into multiple sequences. Such as: When bs = 2, and seqlen = 7, we will have seq_lens = [0, 7, 7, 7, 7, 14, 14, 14, 14] in the prefill attention. In decoding, it won't as it's handled by the gappy bias. Reviewed By: sijiac Differential Revision: D73833204
|
This pull request was exported from Phabricator. Differential Revision: D73833204 |
y-sq
added a commit
to y-sq/FBGEMM-1
that referenced
this pull request
May 21, 2025
Summary: Pull Request resolved: pytorch#4063 X-link: facebookresearch/FBGEMM#1149 When the max_seq_len is larger than 8192, one input sample will be divided into multiple sequences. Such as: When bs = 2, and seqlen = 7, we will have seq_lens = [0, 7, 7, 7, 7, 14, 14, 14, 14] in the prefill attention. In decoding, it won't as it's handled by the gappy bias. Reviewed By: sijiac Differential Revision: D73833204
|
This pull request was exported from Phabricator. Differential Revision: D73833204 |
y-sq
added a commit
to y-sq/FBGEMM-1
that referenced
this pull request
May 21, 2025
Summary: Pull Request resolved: pytorch#4063 X-link: facebookresearch/FBGEMM#1149 When the max_seq_len is larger than 8192, one input sample will be divided into multiple sequences. Such as: When bs = 2, and seqlen = 7, we will have seq_lens = [0, 7, 7, 7, 7, 14, 14, 14, 14] in the prefill attention. In decoding, it won't as it's handled by the gappy bias. Reviewed By: sijiac Differential Revision: D73833204
Summary: Pull Request resolved: pytorch#4063 X-link: facebookresearch/FBGEMM#1149 When the max_seq_len is larger than 8192, one input sample will be divided into multiple sequences. Such as: When bs = 2, and seqlen = 7, we will have seq_lens = [0, 7, 7, 7, 7, 14, 14, 14, 14] in the prefill attention. In decoding, it won't as it's handled by the gappy bias. Reviewed By: sijiac Differential Revision: D73833204
|
This pull request was exported from Phabricator. Differential Revision: D73833204 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
When the max_seq_len is larger than 8192, one input sample will be divided into multiple sequences. Such as:
When bs = 2, and seqlen = 7, we will have seq_lens = [0, 7, 7, 7, 7, 14, 14, 14, 14] in the prefill attention. In decoding, it won't as it's handled by the gappy bias.
Differential Revision: D73833204