Skip to content

Fix: VS Code settings files. "ast.pyi", for example, no longer has 330 diagnostic errors. #14318

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from

Conversation

hunterhogan
Copy link
Contributor

No description provided.

@Akuli Akuli requested a review from Avasam June 26, 2025 21:46
@Avasam
Copy link
Collaborator

Avasam commented Jun 28, 2025

Thanks for assigning, I'll take a deeper look when I can.

At a glance I see a lot more changes than just "let the editor understand more of our setup to reduce false diagnostics".

We also specifically didn't make this a .vscode/settings.json for the reasons explained in the top-level comment. Unless VSCode has since then added a way to locally override a workspace config, we don't want to enforce any of those to other contributors (as well as preventing them form adding more useful configs for their plugins).

A code workspace would also have to duplicate most if not all settings in .vscode/settings.json (usually you go with a workspace, or folder). I'm not sure I see any advantages to using a workspace setup here for typeshed. Care to elaborate ?

@hunterhogan
Copy link
Contributor Author

At a glance I see a lot more changes than just "let the editor understand more of our setup to reduce false diagnostics".

Yeah? Cool story, bro.

Unless VSCode has since then added a way to locally override a workspace config...

"Unless" is doing a lot of work in that sentence--and the entire comment.

Care to elaborate ?

No, not unless the discussion format changes from adversarial to cooperative.

@brianschubert
Copy link
Member

@hunterhogan An abusive tone is not welcome here. Please be mindful of the PSF Code of Conduct.

@hunterhogan
Copy link
Contributor Author

@hunterhogan An abusive tone is not welcome here. Please be mindful of the PSF Code of Conduct.
@brianschubert
As a former prosecutor and certified dispute mediator, I am confident you misused "abusive" and misapplied your voluntary standards.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants