- 
          
- 
                Notifications
    You must be signed in to change notification settings 
- Fork 197
          Use uv venv and uv pip
          #425
        
          New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
uv venv instead of python venvuv venv instead of python -m venv
      There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since pyperformance users include not only CPython but also alternative implementations, I don’t think relying on uv would be a good approach for us to take. cc @hugovk
| 
 
 --python accepts binaries, eg custom PyPy3 build: 
 | 
| No there are a lot of implementations over you listed. e.g RustPython Jython gpython. Let s not make a big huddle to them. | 
| Unless you have a strong motivation to maintain this project based on uv, let's keep it as is based on standard(pip). | 
This is a conversation starter now: should we gradually start moving towards
uvthat handles custom builds, venvs and pinned runs more efficiently?The code already works, confirmed with:
Tests are 2x faster:
I didn't want to do too many changes at once, but in my opinion the best direction would be iterating over each benchmark with
uv.pyperformanceis just a benchmark suite after all, and the whole venv, custom build etc. management makes it unnecessarily complex.Notably,
uv runhas --project, --isolated (now it's isolated if the requirements cannot be met), --with-requirements and --python (supporting custom builds), eg:This is similar to what happens now, just merging temporary outputs.
From what I measured venv management and dependencies only take ~5% of the
runtime, so no dramatic speed up should be expected, but the simplification might be worth it. Important to keep in mind that many features are never ever used, if a large chunk of benchmarks stays broken for so long and some obvious issues lurked for a while.Another elephant in the room is compile that could also be outsourced.
I'm more than open to any suggestions!