Make no-force-push advice linkable #1687
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
itamaro
approved these changes
Nov 12, 2025
Contributor
itamaro
left a comment
itamaro
left a comment
There was a problem hiding this comment.
Nit comments:
- Maybe say "If the PR is merged" instead of "When ..."
- Consider qualifying the guidance with "for published PRs" (afaik it's ok to force push to draft PRs)
Member
Author
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Promote the note to something that can be linked to, so we can easily share it with contributors who force push their PRs.
Add an extra sentence:
"When the PR is merged, everything will be squashed into a single commit."
📚 Documentation preview 📚: https://cpython-devguide--1687.org.readthedocs.build/