Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-128277: remove unnecessary critical section from socket.close #128305

Merged
merged 5 commits into from
Jan 1, 2025
Merged

gh-128277: remove unnecessary critical section from socket.close #128305

merged 5 commits into from
Jan 1, 2025

Conversation

kumaraditya303
Copy link
Contributor

@kumaraditya303 kumaraditya303 commented Dec 28, 2024 •
edited by bedevere-app bot
Loading

@bedevere-app bedevere-app bot mentioned this pull request Dec 28, 2024
Closed
@kumaraditya303 kumaraditya303 marked this pull request as ready for review January 1, 2025 12:18
@kumaraditya303 kumaraditya303 merged commit bb9d955 into python:main Jan 1, 2025
41 checks passed
@kumaraditya303 kumaraditya303 deleted the nocr branch January 1, 2025 12:32
srinivasreddy pushed a commit to srinivasreddy/cpython that referenced this pull request Jan 8, 2025
@kumaraditya303 @srinivasreddy
pythongh-128277: remove unnecessary critical section from `socket.clo…
bc07e75 
…se` (python#128305)

Remove unnecessary critical section from `socket.close` as it now uses relaxed atomics for `sock_fd`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
skip news topic-free-threading
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@kumaraditya303