Py39 generics support #188
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jstasiak is there a chance to review and accept this? |
|
I'll have to see a convincing use case for this feature first – I don't want to officially support some pattern that I don't see a good use for. |
|
@wooyek I'll close due to lack of feedback. Feel free to reopen and provide more information. Thank you for the contribution nonetheless. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I tried to add suport for generics in py39 and make the test from #175 pass.
I don't know what I am doing — python typing scares me :) — but I hope this will help to support generics in modern python versions.
Any comments appreciated.