feat: add backoff wrapper + ai generated docs #2890
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
merolish
approved these changes
Jul 23, 2025
Riateche
approved these changes
Jul 24, 2025
| //! | ||
| //! ## Basic Usage | ||
| //! | ||
| //! ```rust,ignore |
There was a problem hiding this comment.
I think it's better to have an example that at least compiles and use no_run instead of ignore.
There was a problem hiding this comment.
I tried different codes that compiles, it all looks bad and defeats the purpose of showing in a high level how it works.
I'll keep this for now.
lazer/sdk/rust/client/src/client.rs
Outdated
Comment on lines
276
to
281
| /// This initializes the builder with sensible defaults for production use: | ||
| /// - Default Pyth Lazer endpoints | ||
| /// - 4 WebSocket connections | ||
| /// - 5-second timeout | ||
| /// - Default exponential backoff settings | ||
| /// - Default channel capacity |
There was a problem hiding this comment.
Doesn't make sense to list the last two without providing actual values.
There was a problem hiding this comment.
removed them.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
feat: add backoff wrapper + ai generated docs
Rationale
missing improvements from previous PR
How has this been tested?
Ran the example