Skip to content

feat(xc_admin_frontend): add Lazer integration #2722

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 27 commits into
base: main
Choose a base branch
from
Open

Conversation

cctdaniel
Copy link
Contributor

@cctdaniel cctdaniel commented May 23, 2025

Summary

Updated the PythLazer component to display configuration changes in a detailed, structured format similar to PythCore.

Rationale

The original PythLazer component displayed configuration changes as raw JSON, which was difficult to read and understand. This update aligns the user experience with PythCore by:

  • Improved UX: Shows changes in a human-readable table format with clear field names and old/new value comparisons
  • Consistency: Matches the detailed change display style already implemented in PythCore
  • Better Change Visibility: Clearly distinguishes between additions, deletions, and modifications with appropriate titles and strikethrough formatting
  • Type Safety: Properly handles LazerState structure with dedicated components for different change types

The changes also include updates to the underlying validation and type system to properly support the LazerState structure with feeds, publishers, and shard metadata.

How has this been tested?

  • Current tests cover my changes
  • Added new tests
  • Manually tested the code

Manual Testing Steps:

  1. Verified the component renders correctly with the new structured display
  2. Tested upload functionality with sample Lazer configuration files
  3. Confirmed that changes are properly categorized and displayed:
    • Shard configuration changes (shardId, shardName, minRate)
    • Feed changes (metadata fields like minPublishers, symbol, etc.)
    • Publisher changes (name, publicKeys, isActive status)
  4. Validated proper handling of additions, deletions, and modifications
  5. Ensured error handling works correctly with capitalized error messages
  6. Confirmed the modal displays changes with proper formatting and separators

The implementation follows the same patterns as PythCore and integrates seamlessly with the existing validation system and UI components.

Copy link

vercel bot commented May 23, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
api-reference ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 12, 2025 6:32am
component-library 🛑 Canceled (Inspect) Jun 12, 2025 6:32am
developer-hub 🛑 Canceled (Inspect) Jun 12, 2025 6:32am
entropy-debugger ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 12, 2025 6:32am
entropy-explorer ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 12, 2025 6:32am
insights ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 12, 2025 6:32am
proposals ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 12, 2025 6:32am
staking ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 12, 2025 6:32am

@cctdaniel cctdaniel changed the title feat: add initial Lazer integration feat: add Lazer integration May 23, 2025
@vercel vercel bot temporarily deployed to Preview – insights May 23, 2025 04:41 Inactive
@vercel vercel bot temporarily deployed to Preview – entropy-debugger May 23, 2025 04:41 Inactive
@vercel vercel bot temporarily deployed to Preview – staking May 23, 2025 04:41 Inactive
@vercel vercel bot temporarily deployed to Preview – developer-hub May 23, 2025 04:41 Inactive
@vercel vercel bot temporarily deployed to Preview – component-library May 23, 2025 04:41 Inactive
@vercel vercel bot temporarily deployed to Preview – entropy-explorer May 23, 2025 04:41 Inactive
@vercel vercel bot temporarily deployed to Preview – api-reference May 23, 2025 04:41 Inactive
@vercel vercel bot temporarily deployed to Preview – developer-hub May 23, 2025 04:51 Inactive
@vercel vercel bot temporarily deployed to Preview – component-library May 23, 2025 04:51 Inactive
@vercel vercel bot temporarily deployed to Preview – api-reference May 23, 2025 04:51 Inactive
@vercel vercel bot temporarily deployed to Preview – entropy-debugger May 23, 2025 04:51 Inactive
@vercel vercel bot temporarily deployed to Preview – entropy-explorer May 23, 2025 04:51 Inactive
@vercel vercel bot temporarily deployed to Preview – insights May 23, 2025 04:51 Inactive
@vercel vercel bot temporarily deployed to Preview – staking May 23, 2025 04:51 Inactive
@vercel vercel bot temporarily deployed to Preview – entropy-debugger May 23, 2025 05:11 Inactive
@vercel vercel bot temporarily deployed to Preview – component-library May 23, 2025 05:11 Inactive
@vercel vercel bot temporarily deployed to Preview – staking May 23, 2025 05:11 Inactive
@vercel vercel bot temporarily deployed to Preview – entropy-explorer May 23, 2025 05:11 Inactive
@vercel vercel bot temporarily deployed to Preview – developer-hub May 23, 2025 05:11 Inactive
@vercel vercel bot temporarily deployed to Preview – api-reference May 23, 2025 05:11 Inactive
@vercel vercel bot temporarily deployed to Preview – insights May 23, 2025 05:11 Inactive
@vercel vercel bot temporarily deployed to Preview – developer-hub May 23, 2025 08:24 Inactive
@vercel vercel bot temporarily deployed to Preview – entropy-debugger May 23, 2025 08:24 Inactive
@vercel vercel bot temporarily deployed to Preview – component-library May 23, 2025 08:24 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants