feat(fortuna): Support new Entropy v2 contract #2691
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
jayantk
commented
May 15, 2025
| @@ -133,7 +133,7 @@ pub struct EthereumConfig { | |||
| pub legacy_tx: bool, | |||
|
|
|||
| /// The gas limit to use for entropy callback transactions. | |||
| pub gas_limit: u64, | |||
| pub gas_limit: u32, | |||
There was a problem hiding this comment.
u32 is the size of the field in the contract
m30m
reviewed
May 19, 2025
There was a problem hiding this comment.
I think in this new flow we should always make sure that the gas we set for the transaction is more than what the user requested. Now that the users set the gas limit, this is much easier and we can solve the cases where the gas used can vary a lot (from simulation time to landing time) based on other factors.
| .call() | ||
| .await?; | ||
|
|
||
| // sequence_number == 0 means the request does not exist. |
There was a problem hiding this comment.
why is this removed? I know that this check exists in some other places, but if we want to be safe and avoid unintended changes, we can keep it as is?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Update fortuna to set the default_gas_limit field on-chain, and then work with the new Entropy v2 interface. The main changes there are (1) replace the types of ProviderInfo and Request with their V2 variants, and (2) remove the gas_limit parameters from callback submission.
Rationale
we want to support the new version of the contract
How has this been tested?
I've tested this locally against the Entropy contract on blast-testnet (using the EntropyTester to simulate all of the various callback success / failure / out of gas conditions) and it works. I still want to test against a zk chain like Abstract, but that's pending the upgrade right now.