feat: add Rust client for Hermes price service #2686
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
Co-Authored-By: Tejas Badadare <[email protected]>
…ices Co-Authored-By: Tejas Badadare <[email protected]>
Co-Authored-By: Tejas Badadare <[email protected]>
Co-Authored-By: Tejas Badadare <[email protected]>
Co-Authored-By: Tejas Badadare <[email protected]>
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
|
Closing due to inactivity for more than 7 days. |
ali-behjati
reviewed
May 27, 2025
| } | ||
|
|
||
| /// **Deprecated: use /v2/updates/price/latest instead** Get the latest price updates by price feed id. Given a collection of price feed ids, retrieve the latest Pyth price for each price feed. | ||
| pub async fn latest_price_feeds(configuration: &configuration::Configuration, ids_left_square_bracket_right_square_bracket: Vec<String>, verbose: Option<bool>, binary: Option<bool>) -> Result<Vec<models::RpcPriceFeed>, Error<LatestPriceFeedsError>> { |
There was a problem hiding this comment.
ids_left_square_bracket_right_square_bracket lool
There was a problem hiding this comment.
Please rename it to ids
ali-behjati
reviewed
May 27, 2025
apps/hermes/client/rust/Cargo.toml
Outdated
Comment on lines
38
to
40
| [[example]] | ||
| name = "sse_price_stream" | ||
| path = "examples/sse_price_stream.rs" |
Co-Authored-By: Tejas Badadare <[email protected]>
Co-Authored-By: Tejas Badadare <[email protected]>
ali-behjati
approved these changes
May 27, 2025
|
Devin, add a CI to build and test the code like |
Co-Authored-By: Tejas Badadare <[email protected]>
Co-Authored-By: Tejas Badadare <[email protected]>
Co-Authored-By: Tejas Badadare <[email protected]>
ali-behjati
reviewed
May 27, 2025
| --additional-properties=packageName=hermes-client,packageVersion=0.1.0 | ||
| ``` | ||
|
|
||
| 3. Manually update dependencies in Cargo.toml and version number if necessary. |
There was a problem hiding this comment.
add the other step you took here,
- a separate streaming code
- renaming field names to be more intuitive
- fixing format and clippy
Co-Authored-By: Tejas Badadare <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hermes Rust Client
This PR adds a Rust client for the Hermes price service, similar to the existing JavaScript client. The client allows users to interact with the Hermes API to fetch price data and stream real-time price updates.
Implementation Details
eventsource-streamcrate to handle Server-Sent Events properlyFeatures
Testing
The implementation has been tested with example code that:
Link to Devin run: https://app.devin.ai/sessions/68823d31375f4cb9bd88f8d362148446
Requested by: Tejas Badadare