Update entropy documentation to use getFeeV2 instead of getFee #766
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
- Update @pythnetwork/entropy-sdk-solidity package to version 2.0.0 - Update EntropyFeeTable component to use new ABI from package - Switch from getFee(defaultProvider) to getFeeV2() method call - Verified current fees page loads and displays fees correctly Co-Authored-By: Jayant <[email protected]>
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updated entropy documentation to use the newer
getFeeV2method instead of the legacygetFeemethod for retrieving fees. This change involved updating the package dependency to get the correct ABI and modifying the EntropyFeeTable component to use the newer API.Key Changes:
@pythnetwork/entropy-sdk-solidityversion 2.0.0 as a dependency to get updated ABI withgetFeeV2methodsEntropyFeeTable.tsxto import ABI from the new package instead of local ABI filegetFee(defaultProvider)togetFeeV2()which uses the default provider internallyType of Change
Areas Affected
components/EntropyFeeTable.tsx- Updated to usegetFeeV2()method and new ABI sourcepackage.json- Added@pythnetwork/entropy-sdk-solidityversion 2.0.0 dependency/entropy/current-fees) - Behavior verified to work correctlyChecklist
pre-commit run --all-filesto check for linting errors (npm run lint passed)Related Issues
This addresses the request to update entropy documentation to use
getFeeV2instead ofgetFee.Additional Notes
Important Review Points:
@pythnetwork/[email protected]- please verify this version is correct and doesn't conflict with existing dependencies../abis/IEntropy.jsonto package@pythnetwork/entropy-sdk-solidity/abis/IEntropyV2.json- this is a significant change that should be testedgetFeeV2()with no parameters uses the default provider internally, maintaining the same functionality asgetFee(defaultProvider)but using the newer APIVerification Steps:
/entropy/current-feespageContributor Information
Screenshots
The current fees page successfully loads and displays fee data for both mainnet and testnet networks using the updated
getFeeV2()method.