-
-
Notifications
You must be signed in to change notification settings - Fork 2.8k
testing: Explicitly pass -Werror
to tests needing it
#13481
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Explicitly pass `-Werror` to `runpytester()` in the few additional tests needing it, in order to fix test failures when the test suite is run with `-Wdefault` or a similar override. Fixes pytest-dev#13480
The unraisableexception tests were handled in another PR, so this is ready to go. I tweaked the changelog a bit. |
Thanks! |
Backport to 8.4.x: 💚 backport PR created✅ Backport PR branch: Backported as #13538 🤖 @patchback |
testing: Explicitly pass `-Werror` to tests needing it (cherry picked from commit 667398f)
…67398f53b7ca9a19a540054b03d505b84379114/pr-13481 [PR #13481/667398f5 backport][8.4.x] testing: Explicitly pass `-Werror` to tests needing it
@@ -0,0 +1 @@ | |||
Fixed a few test failures in pytest's own test suite when run with ``-Wdefault`` or a similar override. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FTR: since this is not end-user related, probably best as a "trivial" changelog entry, or even not worth having a changelog entry at all.
Explicitly pass
-Werror
torunpytester()
in the few additional tests needing it, in order to fix test failures when the test suite is run with-Wdefault
or a similar override.Fixes #13480
If this change fixes an issue, please:
closes #XYZW
to the PR description and/or commits (whereXYZW
is the issue number). See the github docs for more information.Unless your change is trivial or a small documentation fix (e.g., a typo or reword of a small section) please:
Create a new changelog file in the
changelog
folder, with a name like<ISSUE NUMBER>.<TYPE>.rst
. See changelog/README.rst for details.Write sentences in the past or present tense, examples:
Also make sure to end the sentence with a
.
.Add yourself to
AUTHORS
in alphabetical order.