Skip to content

testing: Explicitly pass -Werror to tests needing it #13481

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 18, 2025

Conversation

mgorny
Copy link
Contributor

@mgorny mgorny commented Jun 3, 2025

Explicitly pass -Werror to runpytester() in the few additional tests needing it, in order to fix test failures when the test suite is run with -Wdefault or a similar override.

Fixes #13480


  • Include documentation when adding new features.
  • Include new tests or update existing tests when applicable.
  • Allow maintainers to push and squash when merging my commits. Please uncheck this if you prefer to squash the commits yourself.

If this change fixes an issue, please:

  • Add text like closes #XYZW to the PR description and/or commits (where XYZW is the issue number). See the github docs for more information.

Unless your change is trivial or a small documentation fix (e.g., a typo or reword of a small section) please:

  • Create a new changelog file in the changelog folder, with a name like <ISSUE NUMBER>.<TYPE>.rst. See changelog/README.rst for details.

    Write sentences in the past or present tense, examples:

    • Improved verbose diff output with sequences.
    • Terminal summary statistics now use multiple colors.

    Also make sure to end the sentence with a ..

  • Add yourself to AUTHORS in alphabetical order.

@psf-chronographer psf-chronographer bot added the bot:chronographer:provided (automation) changelog entry is part of PR label Jun 3, 2025
mgorny added a commit to mgorny/pytest that referenced this pull request Jun 3, 2025
Explicitly pass `-Werror` to `runpytester()` in the few additional
tests needing it, in order to fix test failures when the test suite
is run with `-Wdefault` or a similar override.

Fixes pytest-dev#13480
@bluetech
Copy link
Member

The unraisableexception tests were handled in another PR, so this is ready to go. I tweaked the changelog a bit.

@bluetech bluetech added the backport 8.4.x apply to PRs at any point; backports the changes to the 8.4.x branch label Jun 18, 2025
@mgorny
Copy link
Contributor Author

mgorny commented Jun 18, 2025

Thanks!

@bluetech bluetech added backport 8.4.x apply to PRs at any point; backports the changes to the 8.4.x branch and removed backport 8.4.x apply to PRs at any point; backports the changes to the 8.4.x branch labels Jun 18, 2025
@bluetech bluetech merged commit 667398f into pytest-dev:main Jun 18, 2025
36 checks passed
Copy link

patchback bot commented Jun 18, 2025

Backport to 8.4.x: 💚 backport PR created

✅ Backport PR branch: patchback/backports/8.4.x/667398f53b7ca9a19a540054b03d505b84379114/pr-13481

Backported as #13538

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Jun 18, 2025
testing: Explicitly pass `-Werror` to tests needing it
(cherry picked from commit 667398f)
bluetech added a commit that referenced this pull request Jun 18, 2025
…67398f53b7ca9a19a540054b03d505b84379114/pr-13481

[PR #13481/667398f5 backport][8.4.x] testing: Explicitly pass `-Werror` to tests needing it
@@ -0,0 +1 @@
Fixed a few test failures in pytest's own test suite when run with ``-Wdefault`` or a similar override.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FTR: since this is not end-user related, probably best as a "trivial" changelog entry, or even not worth having a changelog entry at all.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 8.4.x apply to PRs at any point; backports the changes to the 8.4.x branch bot:chronographer:provided (automation) changelog entry is part of PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pytest's test suite fails if run with -Wdefault
3 participants