testing: Explicitly pass -Werror to tests needing it
#13481
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
psf-chronographer
bot
added
the
bot:chronographer:provided
bluetech
reviewed
Jun 3, 2025
mgorny
added a commit
to mgorny/pytest
that referenced
this pull request
Jun 3, 2025
Explicitly pass `-Werror` to `runpytester()` in the few additional tests needing it, in order to fix test failures when the test suite is run with `-Wdefault` or a similar override. Fixes pytest-dev#13480
bluetech
approved these changes
Jun 18, 2025
|
The unraisableexception tests were handled in another PR, so this is ready to go. I tweaked the changelog a bit. |
bluetech
added
the
backport 8.4.x
|
Thanks! |
bluetech
added
backport 8.4.x
Backport to 8.4.x: 💚 backport PR created✅ Backport PR branch: Backported as #13538 🤖 @patchback |
patchback bot
pushed a commit
that referenced
this pull request
Jun 18, 2025
testing: Explicitly pass `-Werror` to tests needing it (cherry picked from commit 667398f)
Merged
6 tasks
bluetech
added a commit
that referenced
this pull request
Jun 18, 2025
…67398f53b7ca9a19a540054b03d505b84379114/pr-13481 [PR #13481/667398f5 backport][8.4.x] testing: Explicitly pass `-Werror` to tests needing it
nicoddemus
reviewed
Jun 18, 2025
| @@ -0,0 +1 @@ | |||
| Fixed a few test failures in pytest's own test suite when run with ``-Wdefault`` or a similar override. | |||
There was a problem hiding this comment.
FTR: since this is not end-user related, probably best as a "trivial" changelog entry, or even not worth having a changelog entry at all.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explicitly pass
-Werrortorunpytester()in the few additional tests needing it, in order to fix test failures when the test suite is run with-Wdefaultor a similar override.Fixes #13480
If this change fixes an issue, please:
closes #XYZWto the PR description and/or commits (whereXYZWis the issue number). See the github docs for more information.Unless your change is trivial or a small documentation fix (e.g., a typo or reword of a small section) please:
Create a new changelog file in the
changelogfolder, with a name like<ISSUE NUMBER>.<TYPE>.rst. See changelog/README.rst for details.Write sentences in the past or present tense, examples:
Also make sure to end the sentence with a
..Add yourself to
AUTHORSin alphabetical order.