Attempt to make codecov less important #1203
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… output and adjust retention days based on branch or tag.
There was a problem hiding this comment.
Pull Request Overview
This PR aims to reduce the emphasis on Codecov by adjusting coverage exclusions in pyproject.toml and modifying the CI workflow to handle coverage reporting differently.
- Update pyproject.toml by excluding "pytest_django/_version.py" in both run and report configurations.
- Revise the CI workflow to use ubuntu-latest, update Tox versions, and introduce dedicated coverage reporting and artifact handling steps.
Reviewed Changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| pyproject.toml | Adds omit rules for excluding pytest_django/_version.py to adjust coverage. |
| .github/workflows/main.yml | Updates runner versions, refactors test steps, and adds a new coverage reporting job. |
Files not reviewed (1)
- tox.ini: Language not supported
Comments suppressed due to low confidence (1)
.github/workflows/main.yml:23
- [nitpick] Changing the runner from a fixed version (ubuntu-24.04) to ubuntu-latest may introduce variability in your CI environment; ensure this change is aligned with your stability requirements.
+ runs-on: ubuntu-latest
There was a problem hiding this comment.
Pull Request Overview
This PR reduces reliance on Codecov by updating coverage exclusions and restructuring the CI workflow for more granular coverage artifact handling.
- Exclude the version file from coverage reports
- Switch CI to ubuntu-latest, update Tox versions, and separate test and coverage-reporting jobs
- Archive individual coverage artifacts and merge them in a dedicated report step
Reviewed Changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated 6 comments.
| File | Description |
|---|---|
| pyproject.toml | Added omit entry to exclude _version.py from coverage runs |
| .github/workflows/main.yml | Updated triggers, runner, Tox versions, and introduced a report-coverage job |
Files not reviewed (1)
- tox.ini: Language not supported
… better clarity and maintainability.
|
@bluetech what do you think of this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #1202
Related to #1201 -- had to close it due to CI not running
This all started because yesterday codecov was having issues, and p!$#ed me off...
This PR aims to reduce the emphasis on Codecov by adjusting coverage exclusions in pyproject.toml and modifying the CI workflow to handle coverage reporting differently.
Miscellaneous:
mainonly