Add pyright hook #1172
Closed
Add pyright hook #1172
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'll close this for now, there's an issue with pyright and pre-commit CI: RobertCraigie/pyright-python#345 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello, I was working with this plugin and encountered this issue.
I added pyright as a pre-commit check with exclusions matching the mypy hook.
This reveals one error involving
function.parentpossibly beingNone. I resolved this by adding an assertion, as that appears to be most consistent with the rest of the codebase.The pre-commit hooks and test suite are passing locally.
Closes #731