Repository navigation
Check permissions and length in fake os.truncate and os.ftruncate - #1343
Open
kratos0718 wants to merge 1 commit into
Open
kratos0718 wants to merge 1 commit into
kratos0718 wants to merge 1 commit into
Conversation
os.truncate succeeded on a read-only file, os.ftruncate truncated a file through a descriptor opened read-only, and a negative length raised ENOSPC. The real calls raise EACCES, EINVAL and EINVAL.
Collaborator
|
Please add an issue so that this change can be tracked in CHANGES.md. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe the changes
os.truncate()on a read-only file succeeded and emptied it; the real call raisesEACCES(checked withis_root()like the other permission checks).os.ftruncate()on a descriptor opened withO_RDONLYtruncated the file; POSIX raisesEINVAL. Left unchanged under Windows, where I could not check the real behavior.ENOSPCfrom the size setter; both calls raiseEINVAL.os.truncate(fd, ...)now goes throughftruncate, so it gets the same checks.The new tests also run against the real fs (
TEST_REAL_FS=1passes on macOS and as a non-root user on Linux), and they fail without the change.Tasks