Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
fe51
left a comment
fe51
left a comment
There was a problem hiding this comment.
Just a functional review from my end.
Thanks for the PR ! ! Having a dedicated page for alerts will be handy for sharing them !
Indeed, the need to scroll isn’t incredible
Also, on a large screen, see screenshot, it leads to this kin. of display, wich is acceptable but not perfect -> This situation that makes us want to address #192 :)
It’s approved as-is for me, since the next updates should be released before users start using this feature (barring accidental discovery by a curious firefighter clicking the “share” button)
Thanks !
| </Grid> | ||
| </Grid> | ||
| )} | ||
| <Snackbar |
There was a problem hiding this comment.
This snackbar is not visible (too far from the button). Maybe we ca reuse the tooltip from the button "CopyToClipboard" ?
| queryFn: getCameraList, | ||
| }); | ||
|
|
||
| const alertsList: AlertType[] = useMemo( |
There was a problem hiding this comment.
It's weird to have an alerts list in a signel alert page
If the mapper mapAlertTypeApiToAlertType takes only a list, maybe we can reafctor the function like this :
mapOneAlertApiToAlertType(alert: AlertApi, cameras: Camera[])
mapListAlertApiToAlertType(alertList: AlertApi[], cameras: Camera[]) {
alertList.map(alert -> mapOneAlertApiToAlertType(alert, cameras);
}
| } | ||
| }, | ||
| "alertPage": { | ||
| "forbiddenTitle": "Accès refusé", |
There was a problem hiding this comment.
Those labels aren't used. Maybe we can redirect to dedicated pages. We already have an ErrorPage
We might need also a forbidden page
3 participants
Enregistrement.de.l.ecran.2026-03-25.a.13.29.58.mov