Update partial_unroll to support markov dims #404
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
#402 (comment) same issue here. |
Member
|
@ordabayevy The issue is fixed now in the master branch. |
…ll-markov merge upstream master
eb8680
approved these changes
Dec 14, 2020
Member
eb8680
left a comment
eb8680
left a comment
There was a problem hiding this comment.
This looks good to me, nice simplification! I just have one nit. (Sorry for the delayed review, I was pretty busy with NeurIPS last week.)
| Currently only plates with history={0, 1} are supported. | ||
| Markov vars are assumed to have names that follow ``var_suffix`` formatting | ||
| (e.g., ``("x_0", "x_prev", "x_curr")``). |
Member
There was a problem hiding this comment.
Can you add an assertion that checks this property of plate_to_step?
Member
Author
|
@eb8680 no worries at all! The assertion checks that |
Member
Author
|
Thanks for reviewing! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
partial_unrollto support unrolling of Markov dimensions (only history=1).var_suffixnaming convention (e.g.,("x_0", "x_prev", "x_curr"))._expected_modified_partial_sum_productis removed.