Fix: Pass auth headers in 2FA and recovery redirects #19223
Closed
+71
−82
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: In two_factor_and_totp_validate and recovery_code, the headers returned by _login_user (which contain the new session/auth cookies) were being ignored. This caused the session to be invalidated immediately after the HTTP 303 redirect.
Fix: captured the headers from _login_user and passed them to HTTPSeeOther.
Related Issue: "Fixes #19222"