Prevent matching bogus parent git directories #687
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If our current directory is not tracked by git we should assume that the project does not use git as the vcs as any match will be a false positive.
jameshilliard
force-pushed
the
check-ignore
branch
from
774ca82 to
0b285ba
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If our current directory is not tracked by git we should assume that the project does not use git as the vcs as any match will be a false positive.
This is a port of this vcs validation check which I added to fix a bug in poetry-core.
Luckily this bug doesn't seem to affect flit-core but I think it's probably a good idea to port the fix to flit anyways.