feat: adding pypy-eol enable group #2393
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
henryiii
force-pushed
the
henryiii/feat/pypy-eol
branch
2 times, most recently
from
f61a0e1 to
7d5c6aa
Compare
Signed-off-by: Henry Schreiner <[email protected]>
henryiii
force-pushed
the
henryiii/feat/pypy-eol
branch
from
7d5c6aa to
9ba08a9
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR adds a new enable group ("pypy-eol") for end-of-life PyPy versions and updates the build selection logic, tests, docs, and schema accordingly.
- Updated test cases to cover the new "pypy-eol" group behavior.
- Modified the BuildSelector logic to separate active PyPy builds from EoL builds.
- Updated documentation and schema definitions to include the new option.
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| unit_test/option_prepare_test.py | Added "pypy-eol" to the enable list for cibuildwheel configuration. |
| unit_test/build_selector_test.py | Adjusted test cases to validate build selection for PyPy and PyPyEoL builds. |
| test/utils.py | Updated expected wheel tags ordering based on PyPyEoL and PyPy conditions. |
| docs/options.md | Documented the new "pypy-eol" option for enabling EoL PyPy builds. |
| cibuildwheel/selector.py | Revised build selection conditions to distinguish between PyPy and PyPyEoL builds. |
| cibuildwheel/resources/cibuildwheel.schema.json | Added "pypy-eol" to the schema for valid configuration options. |
Comments suppressed due to low confidence (1)
unit_test/build_selector_test.py:92
- [nitpick] Consider renaming this test function to a more descriptive name (e.g., 'test_build_selector_skip') to clearly convey its purpose.
def test_skip():
| @@ -87,7 +88,9 @@ def __call__(self, build_id: str) -> bool: | |||
| return False | |||
| if EnableGroup.CPythonPrerelease not in self.enable and fnmatch(build_id, "cp314*"): | |||
| return False | |||
| if EnableGroup.PyPy not in self.enable and fnmatch(build_id, "pp*"): | |||
| if EnableGroup.PyPy not in self.enable and fnmatch(build_id, "pp31*"): | |||
There was a problem hiding this comment.
Consider adding an inline comment to clarify that 'pp31*' is intended to match active PyPy versions, separating them clearly from PyPyEoL builds.
Copilot uses AI. Check for mistakes.
There was a problem hiding this comment.
I'd agree with Copilot on this one!
Suggested change
| if EnableGroup.PyPy not in self.enable and fnmatch(build_id, "pp31*"): | |
| if EnableGroup.PyPy not in self.enable and fnmatch(build_id, "pp31*"): | |
| # PyPy 3.10 and upwards is considered non-EoL. Other versions like | |
| # PyPy 3.9 are matched in the EoL group below. |
There was a problem hiding this comment.
Oh, I missed this. I can add in a follow up, I feel like it is fairly self evident from looking at the code. PyPy and PyPyEoL are right next to each other.
joerick
approved these changes
May 15, 2025
| @@ -87,7 +88,9 @@ def __call__(self, build_id: str) -> bool: | |||
| return False | |||
| if EnableGroup.CPythonPrerelease not in self.enable and fnmatch(build_id, "cp314*"): | |||
| return False | |||
| if EnableGroup.PyPy not in self.enable and fnmatch(build_id, "pp*"): | |||
| if EnableGroup.PyPy not in self.enable and fnmatch(build_id, "pp31*"): | |||
There was a problem hiding this comment.
I'd agree with Copilot on this one!
Suggested change
| if EnableGroup.PyPy not in self.enable and fnmatch(build_id, "pp31*"): | |
| if EnableGroup.PyPy not in self.enable and fnmatch(build_id, "pp31*"): | |
| # PyPy 3.10 and upwards is considered non-EoL. Other versions like | |
| # PyPy 3.9 are matched in the EoL group below. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #2047 (comment).