Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Model creation (BIS) #358

Open
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

EveCharbie
Copy link
Contributor

@EveCharbie EveCharbie commented Jan 20, 2025

This change is Reviewable

@EveCharbie
Copy link
Contributor Author

@pariterre

  1. Yes you were right I commited models without noticing, sorry !
  2. I have issues with the previous tests, and would need your help understanding why.

Copy link
Member

@pariterre pariterre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!
Please update for the last remaining comment and we are good to go :D

Reviewed 20 of 20 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @EveCharbie)


binding/python3/model_creation/segment_real.py line 58 at r1 (raw file):

        if self.rotations != Rotations.NONE:
            out_string += f"\trotations\t{self.rotations.value}\n"
        if self.q_ranges != None:

For very subtle reasons in Python, comparing against None should be done using the "is" operator (instead of the equal operator "=="), as it may leads in some tricky cases to be evaluated as True while False is expected. So this should be changed to:
self.q_ranges is not None

Please change all the occurrences of these (I may have missed some in other files too)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants