Don't use deprecated batched_dot #7951
Open
+2
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fixes Issue pymc-devs#7878 - Replace pt.batched_dot(sqrt_quad.T, sqrt_quad.T) with pt.sum(sqrt_quad.T ** 2, axis=-1) - Computes squared norm per sample using modern PyTensor operations - Eliminates deprecation warnings and ensures future compatibility
Author
|
pre-commit.ci autofix |
for more information, see https://pre-commit.ci
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7951 +/- ##
==========================================
+ Coverage 90.62% 91.48% +0.86%
==========================================
Files 116 116
Lines 18947 18947
==========================================
+ Hits 17170 17333 +163
+ Misses 1777 1614 -163
🚀 New features to boost your workflow:
|
ricardoV94
changed the title
ricardoV94
added
maintenance
no releasenotes
jessegrabowski
requested changes
Nov 11, 2025
| # Square each sample | ||
| quad = pt.batched_dot(sqrt_quad.T, sqrt_quad.T) | ||
| # Square each sample - compute squared norm for each sample | ||
| quad = pt.sum(sqrt_quad.T**2, axis=-1) |
Member
There was a problem hiding this comment.
Suggested change
| quad = pt.sum(sqrt_quad.T**2, axis=-1) | |
| quad = pt.sum(sqrt_quad**2, axis=-2) |
More explicit
Member
There was a problem hiding this comment.
The comment is also incorrect, it's not a "squared norm".
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR replaces the deprecated
pt.batched_dotfunction with the preferredpt.sumoperation in the KroneckerNormal distribution's logprob calculation, addressing issue #7878.Problem
The current implementation uses
batched_dot, which is deprecated in PyTensor and triggers warnings. Deprecated functions may lead to future breakage and lower performance.Solution
Refactored the
KroneckerNormallogprob code to usept.sumwith explicit axis parameters, achieving the same functionality without relying on deprecated APIs.Tests
Related Issue
Fixes #7878
Checklist
📚 Documentation preview 📚: https://pymc--7951.org.readthedocs.build/en/7951/