[primer] Create a class for easier comparison of pylint results by Pierre-Sassoulas · Pull Request #6984 · pylint-dev/pylint

Pierre-Sassoulas · 2022-06-20T12:24:36Z

Type of Changes

	Type
✓	🔨 Refactoring

Description

Follow up to #6973

coveralls · 2022-06-20T12:33:03Z

Pull Request Test Coverage Report for Build 2528939077

37 of 37 (100.0%) changed or added relevant lines in 3 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.002%) to 95.287%

Totals
Change from base Build 2527590849:	0.002%
Covered Lines:	16600
Relevant Lines:	17421

💛 - Coveralls

DanielNoord · 2025-03-30T15:15:45Z

@Pierre-Sassoulas I would be okay with rebasing this and not doing the rename if that means we can merge this easily :)

Pierre-Sassoulas · 2025-03-30T15:27:49Z

I think there was a concurrent change that forced to redo everything or at least a lot. (Which is why it's stuck not the rename). Might aknowledge the loss and redo from scratch later instead of trying to rebase then getting demoralised :) Also there was a gazillion thing on my todo list before that (too-few-logging and always suggest for no-member) but we now have a cache problem to fix first :D...

Move cross-referencing and JSON loading from CompareCommand into a dedicated PylintComparator class with an abstract Comparator base, enabling future comparator implementations (e.g. AstroidComparator). Closes #6984

Move cross-referencing and JSON loading from CompareCommand into a dedicated PylintComparator class with an abstract Comparator base, enabling future comparator implementations (e.g. AstroidComparator). Closes pylint-dev#6984

codecov · 2026-03-16T12:19:39Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.16%. Comparing base (236eb8a) to head (fe2d79d).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #6984   +/-   ##
=======================================
  Coverage   96.16%   96.16%           
=======================================
  Files         177      178    +1     
  Lines       19617    19627   +10     
=======================================
+ Hits        18865    18875   +10     
  Misses        752      752

Files with missing lines	Coverage Δ
pylint/testutils/_primer/comparator.py	`100.00% <100.00%> (ø)`
pylint/testutils/_primer/primer_compare_command.py	`94.91% <100.00%> (-1.68%)`	⬇️

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

DanielNoord

Cool! Some small nits, but I'll stay on top of reviewing this so we can merge this and not let this get stale again.

DanielNoord · 2026-03-16T21:46:24Z

+
+from pylint.testutils._primer.comparator import Comparator
+
+FIXTURES_PATH = Path(__file__).parent / "fixtures"


Suggested change

FIXTURES_PATH = Path(__file__).parent / "fixtures"

CASES_PATH = Path(__file__).parent / "cases"

DanielNoord · 2026-03-16T21:46:35Z

+    [
+        pytest.param(p, id=p.name)
+        for p in FIXTURES_PATH.iterdir()
+        if p.is_dir() and p.name != "batched"  # tested separately


Perhaps just move that case out of the directory then?

DanielNoord · 2026-03-17T19:30:42Z

@Pierre-Sassoulas Feels like a rebase went wrong here? There are some unrelated dependency updates in this PR.

DanielNoord

Except for the unrelated changes this LGTM!

@Pierre-Sassoulas Can you rebase again? I'll approve and merge afterwards!

Move the ``# pylint: enable=duplicate-code`` comment after the ``tempdir`` context manager so it is covered by the existing suppression scope.

Move JSON loading, batching, and cross-referencing logic into a dedicated Comparator class. CompareCommand.run() now delegates to the Comparator and iterates over it to build the comment.

Pierre-Sassoulas · 2026-03-17T19:56:46Z

The duplicate-code change is required, I don't know why it suddenly fails, probably that the pre-commit grouping changed by adding new files.

github-actions · 2026-03-17T20:23:01Z

🤖 According to the primer, this change has no effect on the checked open source code. 🤖🎉

This comment was generated for commit fe2d79d

Pierre-Sassoulas added the Maintenance Discussion or action around maintaining pylint or the dev workflow label Jun 20, 2022

Pierre-Sassoulas force-pushed the refactor-primer_comparator branch from 0915546 to a54c77e Compare June 20, 2022 12:27

Pierre-Sassoulas requested a review from DanielNoord June 20, 2022 12:27

This comment has been minimized.

Sign in to view

DanielNoord requested changes Jun 20, 2022

View reviewed changes

Comment thread pylint/testutils/_primer/comparator.py Outdated

Comment thread pylint/testutils/_primer/primer_command.py Outdated

Comment thread pylint/testutils/_primer/comparator.py

Pierre-Sassoulas mentioned this pull request Jun 22, 2022

[primer] Refactor the primer to use 'pylint.message.Message' #7000

Merged

jacobtylerwalls added the primer label Jul 10, 2022

Pierre-Sassoulas added the Skip news 🔇 This change does not require a changelog entry label Jul 31, 2022

Pierre-Sassoulas mentioned this pull request Nov 9, 2022

Better primer tests : more reliable, easier to understand, and more stable #7738

Open

6 tasks

Pierre-Sassoulas force-pushed the refactor-primer_comparator branch from a54c77e to c153227 Compare February 24, 2023 19:35

Pierre-Sassoulas force-pushed the refactor-primer_comparator branch from c153227 to b0fa36d Compare March 16, 2026 12:04

This comment has been minimized.

Sign in to view

Pierre-Sassoulas requested a review from DanielNoord March 16, 2026 12:43

Pierre-Sassoulas force-pushed the refactor-primer_comparator branch from b3e6e4f to 7702cbb Compare March 16, 2026 12:53

This comment has been minimized.

Sign in to view

Pierre-Sassoulas force-pushed the refactor-primer_comparator branch from 7702cbb to ac37fbf Compare March 16, 2026 13:31

This comment has been minimized.

Sign in to view

DanielNoord reviewed Mar 16, 2026

View reviewed changes

Pierre-Sassoulas force-pushed the refactor-primer_comparator branch 2 times, most recently from 67f7cb5 to 617848e Compare March 17, 2026 17:11

Pierre-Sassoulas requested a review from DanielNoord March 17, 2026 17:12

This comment has been minimized.

Sign in to view

Pierre-Sassoulas force-pushed the refactor-primer_comparator branch from 617848e to 4eef601 Compare March 17, 2026 19:23

DanielNoord reviewed Mar 17, 2026

View reviewed changes

This comment has been minimized.

Sign in to view

Pierre-Sassoulas added 2 commits March 17, 2026 20:55

Extend duplicate-code disable to cover tempdir helper

345504d

Move the ``# pylint: enable=duplicate-code`` comment after the ``tempdir`` context manager so it is covered by the existing suppression scope.

Extract Comparator class from CompareCommand

fe2d79d

Move JSON loading, batching, and cross-referencing logic into a dedicated Comparator class. CompareCommand.run() now delegates to the Comparator and iterates over it to build the comment.

Pierre-Sassoulas force-pushed the refactor-primer_comparator branch from 4eef601 to fe2d79d Compare March 17, 2026 19:55

Pierre-Sassoulas enabled auto-merge (rebase) March 17, 2026 20:17

DanielNoord approved these changes Mar 17, 2026

View reviewed changes

DanielNoord disabled auto-merge March 17, 2026 20:40

DanielNoord merged commit d796007 into pylint-dev:main Mar 17, 2026
42 checks passed

DanielNoord deployed to Backport March 17, 2026 20:40 — with GitHub Actions Active


		from pylint.testutils._primer.comparator import Comparator

		FIXTURES_PATH = Path(__file__).parent / "fixtures"

	FIXTURES_PATH = Path(__file__).parent / "fixtures"
	CASES_PATH = Path(__file__).parent / "cases"

Uh oh!

Conversation

Pierre-Sassoulas commented Jun 20, 2022

Type of Changes

Description

Uh oh!

coveralls commented Jun 20, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pull Request Test Coverage Report for Build 2528939077

💛 - Coveralls

Uh oh!

This comment has been minimized.

Uh oh!

Uh oh!

Uh oh!

DanielNoord commented Mar 30, 2025

Uh oh!

Pierre-Sassoulas commented Mar 30, 2025

Uh oh!

codecov Bot commented Mar 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

DanielNoord left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

DanielNoord Mar 16, 2026

Choose a reason for hiding this comment

Uh oh!

DanielNoord Mar 16, 2026

Choose a reason for hiding this comment

Uh oh!

This comment has been minimized.

DanielNoord commented Mar 17, 2026

Uh oh!

DanielNoord left a comment

Choose a reason for hiding this comment

Uh oh!

This comment has been minimized.

Pierre-Sassoulas commented Mar 17, 2026

Uh oh!

github-actions Bot commented Mar 17, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

coveralls commented Jun 20, 2022 •

edited

Loading

codecov Bot commented Mar 16, 2026 •

edited

Loading