Add support for isort option --known-first-party
#10803
Open
+59
−13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix regression in 6ce6032: In `__init__` the options are not parsed yet and hence will always be the defaults.
Flamefire
force-pushed
the
first-party-imports
branch
from
4852254 to
bd160ae
Compare
Flamefire
force-pushed
the
first-party-imports
branch
from
bd160ae to
070dac1
Compare
Flamefire
changed the title
--known-first-party
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #10803 +/- ##
=======================================
Coverage 95.98% 95.98%
=======================================
Files 176 176
Lines 19564 19567 +3
=======================================
+ Hits 18779 18782 +3
Misses 785 785
🚀 New features to boost your workflow:
|
DanielNoord
reviewed
Jan 6, 2026
Collaborator
DanielNoord
left a comment
DanielNoord
left a comment
There was a problem hiding this comment.
@Pierre-Sassoulas Is this option something we want to add?
This comment has been minimized.
This comment has been minimized.
Flamefire
force-pushed
the
first-party-imports
branch
from
f161aa6 to
288f0f7
Compare
Flamefire
force-pushed
the
first-party-imports
branch
from
270b3bd to
710916d
Compare
Author
|
Motivation for me was that we have a project that uses a Rather than doing a large-scale refactoring adding this exception is the easiest way out. It would be even better if PyLint would understand the |
Contributor
|
🤖 According to the primer, this change has no effect on the checked open source code. 🤖🎉 This comment was generated for commit 710916d |
With the fix of honoring the config the import is now correctly identified using the overwrite `known-standard-library=_string`
Similar to known-third-party this recognizes modules as first party modules.
Flamefire
force-pushed
the
first-party-imports
branch
from
710916d to
ceba49f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Changes
Description
Add support for
--known-first-partysimilar to--known-third-party:Force import order to recognize a module as part of a first party library.
Based on #10802 as otherwise tests would fail