Port Texture to C code #3330
Open
Port Texture to C code #3330
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
commit 813f384 Author: Josip Komljenović <[email protected]> Date: Wed Jan 29 15:43:45 2025 +0100 Add interface for _sdl2.video classes commit 702958c Author: Josip Komljenović <[email protected]> Date: Wed Jan 29 15:38:01 2025 +0100 Add interface for _sdl2.video classes commit 081b032 Author: Josip Komljenović <[email protected]> Date: Wed Jan 29 15:33:20 2025 +0100 Add interface for _sdl2.video classes commit c9ffd1c Author: Josip Komljenović <[email protected]> Date: Wed Jan 29 15:25:10 2025 +0100 Add interface for _sdl2.video classes
commit 813f384 Author: Josip Komljenović <[email protected]> Date: Wed Jan 29 15:43:45 2025 +0100 Add interface for _sdl2.video classes commit 702958c Author: Josip Komljenović <[email protected]> Date: Wed Jan 29 15:38:01 2025 +0100 Add interface for _sdl2.video classes commit 081b032 Author: Josip Komljenović <[email protected]> Date: Wed Jan 29 15:33:20 2025 +0100 Add interface for _sdl2.video classes commit c9ffd1c Author: Josip Komljenović <[email protected]> Date: Wed Jan 29 15:25:10 2025 +0100 Add interface for _sdl2.video classes
This was referenced Feb 7, 2025
Starbuck5
reviewed
Jun 21, 2025
| @@ -629,12 +1234,14 @@ static PyTypeObject pgRenderer_Type = { | |||
| .tp_getset = renderer_getset}; | |||
|
|
|||
| static PyTypeObject pgTexture_Type = { | |||
| PyVarObject_HEAD_INIT(NULL, 0).tp_name = "pygame._render.Texture", | |||
| PyVarObject_HEAD_INIT(NULL, 0).tp_name = "pygame._renderer.Texture", | |||
There was a problem hiding this comment.
It's the render module, not the renderer module
Starbuck5
reviewed
Jun 21, 2025
| else { | ||
| access = SDL_TEXTUREACCESS_STATIC; | ||
| } | ||
| self->renderer = renderer; |
There was a problem hiding this comment.
Wouldn't this need to be incref-ed?
Starbuck5
reviewed
Jun 21, 2025
| if (!new_texture->texture) { | ||
| return RAISE(pgExc_SDLError, SDL_GetError()); | ||
| } | ||
| new_texture->renderer = renderer; |
There was a problem hiding this comment.
Same concern here about refcounting.
Starbuck5
reviewed
Jun 21, 2025
| texture_set_blend_mode(pgTextureObject *self, PyObject *arg, void *closure) | ||
| { | ||
| if (PyLong_Check(arg)) { | ||
| long longval = PyLong_AsLong(arg); |
There was a problem hiding this comment.
Technically this function could fail and return -1 with an error set, which you're not checking.
Rather than doing PyLong_Check + PyLong_AsLong you could just do PyLong_AsLong and check it succeeds?
Starbuck5
reviewed
Jun 21, 2025
| if (!pg_TwoFloatsFromObj(originobj, &origin.x, &origin.y)) { | ||
| return RAISE(PyExc_ValueError, "origin must be a point or None"); | ||
| } | ||
| originptr = &origin; |
There was a problem hiding this comment.
You could pass &origin into SDL_RenderCopyExF directly rather than needing this extra variable. (I see the Cython has it, maybe it's a weird Cython thing or the person who wrote it wasn't as experienced with pointers).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR converts pygame._sdl2.video.Texture to C code. It has the implementation of all the Texture methods and attributes.
TODO: fix Renderer.target reference counting in set_target