Enforce integer type on counting tensor for mean aggregation#10624
Open
Shono1 wants to merge 1 commit intopyg-team:masterfrom
Open
Enforce integer type on counting tensor for mean aggregation#10624Shono1 wants to merge 1 commit intopyg-team:masterfrom
Shono1 wants to merge 1 commit intopyg-team:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Attempting to use mean aggregation with complex-valued node features leads to a crash. This occurs because the tensor storing the "denominator" for the mean calculation (
count) inherits the type of the node encodings. The program crashes whenclampis called oncount, asclampis (correctly) incompatible with complex numbers.Count should really be an integer in all cases, so in this pull request I enforce that by explicitly setting the dtype when creating the tensor of zeros from
src, and in creating the tensor of ones fromsrcthat gets added to it.